Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4135)

Unified Diff: chrome/common/extensions/extension_permission_set.cc

Issue 10310028: Making webRequest.addEventListener internal (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing ExtensionPermissionsTest.PermissionMessages unit-test for WebRequestInternal Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension_permission_set.cc
diff --git a/chrome/common/extensions/extension_permission_set.cc b/chrome/common/extensions/extension_permission_set.cc
index cf2e40f802a4d89f8f1e46748cda540280f978c6..f7af1104bb0a45031bafee5cc060bf16c35ec996 100644
--- a/chrome/common/extensions/extension_permission_set.cc
+++ b/chrome/common/extensions/extension_permission_set.cc
@@ -322,6 +322,9 @@ void ExtensionAPIPermission::RegisterAllPermissions(
kTerminalPrivate, "terminalPrivate", 0, ExtensionPermissionMessage::kNone,
kFlagCannotBeOptional);
info->RegisterPermission(
+ kWebRequestInternal, "webRequestInternal", 0,
+ ExtensionPermissionMessage::kNone, kFlagCannotBeOptional);
+ info->RegisterPermission(
kWebSocketProxyPrivate, "webSocketProxyPrivate", 0,
ExtensionPermissionMessage::kNone,
kFlagCannotBeOptional);
@@ -875,6 +878,10 @@ void ExtensionPermissionSet::InitImplicitExtensionPermissions(
if (!extension->devtools_url().is_empty())
apis_.insert(ExtensionAPIPermission::kDevtools);
+ // The webRequest permission implies the internal version as well.
+ if (apis_.find(ExtensionAPIPermission::kWebRequest) != apis_.end())
+ apis_.insert(ExtensionAPIPermission::kWebRequestInternal);
+
// Add the scriptable hosts.
for (UserScriptList::const_iterator content_script =
extension->content_scripts().begin();
« no previous file with comments | « chrome/common/extensions/extension_permission_set.h ('k') | chrome/common/extensions/extension_permission_set_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698