runtime/bin/file_linux.cc - Issue 10309004: Deal with symbolic links for file and directories on Mac and Linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/file_linux.cc

Issue 10309004: Deal with symbolic links for file and directories on Mac and Linux. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/file_linux.cc

diff --git a/runtime/bin/file_linux.cc b/runtime/bin/file_linux.cc

index 03dd50a1077758f4cf2f0058dbe35640f819bf23..3f93bd363da769344e250eecdf851119bcc9eb03 100644

--- a/runtime/bin/file_linux.cc

+++ b/runtime/bin/file_linux.cc

@@ -140,7 +140,7 @@ File* File::OpenStdio(int fd) {

bool File::Exists(const char* name) {

struct stat st;

if (TEMP_FAILURE_RETRY(stat(name, &st)) == 0) {

- return S_ISREG(st.st_mode); // Deal with symlinks?

+ return S_ISREG(st.st_mode);

} else {

return false;

}

« no previous file with comments | « runtime/bin/directory_posix.cc ('k') | runtime/bin/file_macos.cc » ('j') | no next file with comments »