MSVS: Fix to ensure that actions are re-run when the action command changes

test/actions-args-change/gyptest-all.py

Index: test/actions-args-change/gyptest-all.py
diff --git a/test/actions-args-change/gyptest-all.py b/test/actions-args-change/gyptest-all.py
new file mode 100755
index 0000000000000000000000000000000000000000..0a9a3e33cde554feb0b6ef3fdcb450f1cac4477b
--- /dev/null
+++ b/test/actions-args-change/gyptest-all.py
@@ -0,0 +1,48 @@
+#!/usr/bin/env python
+
+# Copyright (c) 2012 Google Inc. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""
+Verifies that actions get re-run when their arguments change.
+
+This is a regression test for http://code.google.com/p/gyp/issues/detail?id=262
+"""
+
+import os
+
+import TestGyp
+
+
+def ReadFile(filename):
+  fh = open(filename, "r")
+  try:
+    return fh.read()
+  finally:
+    fh.close()
+
+
+def WriteFile(filename, data):
+  fh = open(filename, "w")
+  try:
+    fh.write(data)
+  finally:
+    fh.close()
+
+
+test = TestGyp.TestGyp()
+
+test.run_gyp('arg-action.gyp', chdir='src')
+test.build('arg-action.gyp', chdir='src')
+test.built_file_must_match('dest-file.txt', 'ARG_VALUE_1', chdir='src')
+
+gypi_file = os.path.join(test.workdir, 'src', 'arg-action.gypi')
+data = ReadFile(gypi_file)
+WriteFile(gypi_file, data.replace('ARG_VALUE_1', 'ARG_VALUE_2'))

[jeanluc1, 2012/05/02 23:13:52]

Are you sure you'll be able to overwrite this file?  Could be set as read-only
in some case as it is extracted from the version control system?  I'd be more
comfortable if you write the file twice (as _1 and as _2) to a path different
than what is in the version control system.

[Mark Seaborn, 2012/05/02 23:38:32]

You mean you're concerned that the test will fail if you do

  chmod -w test/actions-args-change/src/arg-action.gypi

beforehand, because it's copying the permission bits?  It does indeed fail on
Linux if I do that.

It seems rather obnoxious to copy the permission bits like this in a test,
though.  Maybe I should change TestGyp not to do that, and only copy the
executable bit?

[jeanluc1, 2012/05/02 23:50:24]

I was concerned that some version control systems by default copy file as
read-only until you specify that you want to edit the file.

On 2012/05/02 23:38:32, Mark Seaborn wrote:

[Mark Seaborn, 2012/05/03 00:39:20]

Sure, I see what you mean.  Do you want me to fix the test to work in that case?
 It seems like the most general way would be to ensure that we write the file
with the writable permission bit set in copy_test_configuration() in TestGyp.py?

+
+test.run_gyp('arg-action.gyp', chdir='src')
+test.build('arg-action.gyp', chdir='src')
+test.built_file_must_match('dest-file.txt', 'ARG_VALUE_2', chdir='src')
+
+test.pass_test()