Do not externalize Dart strings as C strings for "print()".

runtime/vm/dart_api_impl.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_api.h"
 
 #include "vm/bigint_operations.h"
 #include "vm/class_finalizer.h"
 #include "vm/compiler.h"
 #include "vm/dart.h"
 #include "vm/dart_api_impl.h"
 #include "vm/dart_api_message.h"
 #include "vm/dart_api_state.h"
 #include "vm/dart_entry.h"
 #include "vm/debuginfo.h"
 #include "vm/exceptions.h"
 #include "vm/flags.h"
 #include "vm/growable_array.h"
 #include "vm/message.h"
 #include "vm/native_entry.h"
 #include "vm/native_message_handler.h"
 #include "vm/object.h"
 #include "vm/object_store.h"
 #include "vm/port.h"
 #include "vm/resolver.h"
 #include "vm/stack_frame.h"
 #include "vm/timer.h"
+#include "vm/unicode.h"
 #include "vm/verifier.h"
 
 namespace dart {
 
 DECLARE_FLAG(bool, print_class_table);
 
 ThreadLocalKey Api::api_native_key_ = Thread::kUnsetThreadLocalKey;
 
 const char* CanonicalFunction(const char* func) {
   if (strncmp(func, "dart::", 6) == 0) {
@@ skipping 1566 matching lines @@
     }
     strncpy(res, string_value, string_length + 1);
     ASSERT(res[string_length] == '\0');
     *result = res;
     return Api::Success(isolate);
   }
   return Api::NewError("Object is not a String");
 }
 
 
+DART_EXPORT Dart_Handle Dart_StringToBytes(Dart_Handle object,
+                                           const uint8_t** bytes,
+                                           intptr_t *length) {
+  Isolate* isolate = Isolate::Current();
+  DARTSCOPE(isolate);
+  const String& str = Api::UnwrapStringHandle(isolate, object);
+  if (str.IsNull()) {
+    RETURN_TYPE_ERROR(isolate, object, String);
+  }
+  if (bytes == NULL) {
+    return Api::NewError("%s expects argument 'bytes' to be non-null.",
+                         CURRENT_FUNC);
+  }
+  if (length == NULL) {
+    return Api::NewError("%s expects argument 'length' to be non-null.",
+                        CURRENT_FUNC);
+  }
+  const char* cstring = str.ToCString();
+  *length = Utf8::Length(str);
+  char* result = reinterpret_cast<char*>(Api::Allocate(isolate, *length));
+  if (result == NULL) {
+    return Api::NewError("Unable to allocate memory");
+  }
+  memmove(result, cstring, *length);
+  *bytes = result;
+  return Api::Success(isolate);
+}
+
+
 // --- Lists ---
 
 
 static RawInstance* GetListInstance(Isolate* isolate, const Object& obj) {
   if (obj.IsInstance()) {
     Instance& instance = Instance::Handle(isolate);
     instance ^= obj.raw();
     const Type& type =
         Type::Handle(isolate, isolate->object_store()->list_interface());
     Error& malformed_type_error = Error::Handle(isolate);
@@ skipping 1668 matching lines @@
       *buffer = NULL;
     }
     delete debug_region;
   } else {
     *buffer = NULL;
     *buffer_size = 0;
   }
 }
 
 }  // namespace dart