Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Unified Diff: net/url_request/url_request_context_builder_unittest.cc

Issue 10299002: Stop refcounting URLRequestContext. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Initialize to NULL Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/url_request/url_request_context_builder.cc ('k') | net/url_request/url_request_ftp_job.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_context_builder_unittest.cc
diff --git a/net/url_request/url_request_context_builder_unittest.cc b/net/url_request/url_request_context_builder_unittest.cc
index 8fcb19c2aa52dbc73881b777f6c4864496537fec..2908c51e790fb7375633902362fb58caca847f4f 100644
--- a/net/url_request/url_request_context_builder_unittest.cc
+++ b/net/url_request/url_request_context_builder_unittest.cc
@@ -53,10 +53,10 @@ class URLRequestContextBuilderTest : public PlatformTest {
TEST_F(URLRequestContextBuilderTest, DefaultSettings) {
ASSERT_TRUE(test_server_.Start());
- scoped_refptr<URLRequestContext> context = builder_.Build();
+ scoped_ptr<URLRequestContext> context(builder_.Build());
TestDelegate delegate;
URLRequest request(test_server_.GetURL("echoheader?Foo"), &delegate);
- request.set_context(context);
+ request.set_context(context.get());
request.set_method("GET");
request.SetExtraRequestHeaderByName("Foo", "Bar", false);
request.Start();
@@ -68,10 +68,10 @@ TEST_F(URLRequestContextBuilderTest, UserAgent) {
ASSERT_TRUE(test_server_.Start());
builder_.set_user_agent("Bar");
- scoped_refptr<URLRequestContext> context = builder_.Build();
+ scoped_ptr<URLRequestContext> context(builder_.Build());
TestDelegate delegate;
URLRequest request(test_server_.GetURL("echoheader?User-Agent"), &delegate);
- request.set_context(context);
+ request.set_context(context.get());
request.set_method("GET");
request.Start();
MessageLoop::current()->Run();
« no previous file with comments | « net/url_request/url_request_context_builder.cc ('k') | net/url_request/url_request_ftp_job.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698