Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1120)

Unified Diff: net/url_request/url_request.cc

Issue 10299002: Stop refcounting URLRequestContext. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: More fixes Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request.cc
diff --git a/net/url_request/url_request.cc b/net/url_request/url_request.cc
index d3fa6d1256487cdc2cd82fd9a29203b5e5b079cc..8a03b5da530b5e3213b059d1b5ab3f3cb264be44 100644
--- a/net/url_request/url_request.cc
+++ b/net/url_request/url_request.cc
@@ -132,7 +132,8 @@ void URLRequest::Delegate::OnSSLCertificateError(URLRequest* request,
// URLRequest
URLRequest::URLRequest(const GURL& url, Delegate* delegate)
- : url_chain_(1, url),
+ : context_(NULL),
+ url_chain_(1, url),
method_("GET"),
load_flags_(LOAD_NORMAL),
delegate_(delegate),
@@ -722,7 +723,7 @@ int URLRequest::Redirect(const GURL& location, int http_status_code) {
}
const URLRequestContext* URLRequest::context() const {
- return context_.get();
+ return context_;
}
void URLRequest::set_context(const URLRequestContext* context) {
eroman 2012/05/04 04:27:02 sidecomment: are there any legitimate use cases fo
@@ -739,7 +740,7 @@ void URLRequest::set_context(const URLRequestContext* context) {
url_requests->insert(this);
}
- scoped_refptr<const URLRequestContext> prev_context = context_;
+ const URLRequestContext* prev_context = context_;
context_ = context;

Powered by Google App Engine
This is Rietveld 408576698