content/shell/shell_url_request_context_getter.h - Issue 10299002: Stop refcounting URLRequestContext.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/shell_url_request_context_getter.h

Issue 10299002: Stop refcounting URLRequestContext. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: More fixes Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/shell/shell_url_request_context_getter.h

diff --git a/content/shell/shell_url_request_context_getter.h b/content/shell/shell_url_request_context_getter.h

index 4de8bb88272b4d1310b88cbbf692cd8d3a8e1a32..6aa7b01f472d2bd21ae078c31e12db4ecc60e1c1 100644

--- a/content/shell/shell_url_request_context_getter.h

+++ b/content/shell/shell_url_request_context_getter.h

@@ -46,10 +46,9 @@ class ShellURLRequestContextGetter : public net::URLRequestContextGetter {

MessageLoop* file_loop_;

scoped_ptr<net::ProxyConfigService> proxy_config_service_;

- scoped_refptr<net::URLRequestContext> url_request_context_;

- scoped_ptr<net::URLRequestContextStorage> storage_;

scoped_ptr<net::NetworkDelegate> network_delegate_;

+ scoped_ptr<net::URLRequestContext> url_request_context_;

+ scoped_ptr<net::URLRequestContextStorage> storage_;

eroman 2012/05/04 04:27:02 Feels like the storage should probably outlive url

DISALLOW_COPY_AND_ASSIGN(ShellURLRequestContextGetter);

};