Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Side by Side Diff: src/arm/stub-cache-arm.cc

Issue 10298010: ARM: Ensure reload of elements pointer in StoreFastDoubleElement stub (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4457 matching lines...) Expand 10 before | Expand all | Expand 10 after
4468 // Install the new backing store in the JSArray. 4468 // Install the new backing store in the JSArray.
4469 __ str(elements_reg, 4469 __ str(elements_reg,
4470 FieldMemOperand(receiver_reg, JSObject::kElementsOffset)); 4470 FieldMemOperand(receiver_reg, JSObject::kElementsOffset));
4471 __ RecordWriteField(receiver_reg, JSObject::kElementsOffset, elements_reg, 4471 __ RecordWriteField(receiver_reg, JSObject::kElementsOffset, elements_reg,
4472 scratch1, kLRHasNotBeenSaved, kDontSaveFPRegs, 4472 scratch1, kLRHasNotBeenSaved, kDontSaveFPRegs,
4473 EMIT_REMEMBERED_SET, OMIT_SMI_CHECK); 4473 EMIT_REMEMBERED_SET, OMIT_SMI_CHECK);
4474 4474
4475 // Increment the length of the array. 4475 // Increment the length of the array.
4476 __ mov(length_reg, Operand(Smi::FromInt(1))); 4476 __ mov(length_reg, Operand(Smi::FromInt(1)));
4477 __ str(length_reg, FieldMemOperand(receiver_reg, JSArray::kLengthOffset)); 4477 __ str(length_reg, FieldMemOperand(receiver_reg, JSArray::kLengthOffset));
4478 __ ldr(elements_reg,
4479 FieldMemOperand(receiver_reg, JSObject::kElementsOffset));
4478 __ jmp(&finish_store); 4480 __ jmp(&finish_store);
4479 4481
4480 __ bind(&check_capacity); 4482 __ bind(&check_capacity);
4481 // Make sure that the backing store can hold additional elements. 4483 // Make sure that the backing store can hold additional elements.
4482 __ ldr(scratch1, 4484 __ ldr(scratch1,
4483 FieldMemOperand(elements_reg, FixedDoubleArray::kLengthOffset)); 4485 FieldMemOperand(elements_reg, FixedDoubleArray::kLengthOffset));
4484 __ cmp(length_reg, scratch1); 4486 __ cmp(length_reg, scratch1);
4485 __ b(hs, &slow); 4487 __ b(hs, &slow);
4486 4488
4487 // Grow the array and finish the store. 4489 // Grow the array and finish the store.
4488 __ add(length_reg, length_reg, Operand(Smi::FromInt(1))); 4490 __ add(length_reg, length_reg, Operand(Smi::FromInt(1)));
4489 __ str(length_reg, FieldMemOperand(receiver_reg, JSArray::kLengthOffset)); 4491 __ str(length_reg, FieldMemOperand(receiver_reg, JSArray::kLengthOffset));
4490 __ jmp(&finish_store); 4492 __ jmp(&finish_store);
4491 4493
4492 __ bind(&slow); 4494 __ bind(&slow);
4493 Handle<Code> ic_slow = masm->isolate()->builtins()->KeyedStoreIC_Slow(); 4495 Handle<Code> ic_slow = masm->isolate()->builtins()->KeyedStoreIC_Slow();
4494 __ Jump(ic_slow, RelocInfo::CODE_TARGET); 4496 __ Jump(ic_slow, RelocInfo::CODE_TARGET);
4495 } 4497 }
4496 } 4498 }
4497 4499
4498 4500
4499 #undef __ 4501 #undef __
4500 4502
4501 } } // namespace v8::internal 4503 } } // namespace v8::internal
4502 4504
4503 #endif // V8_TARGET_ARCH_ARM 4505 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698