Issue 10291007: Added support in Metro mode for retrieving the information about the currently

Issue 10291007: Added support in Metro mode for retrieving the information about the currently (Closed)

Created:
8 years, 7 months ago by ananta

Modified:
8 years, 7 months ago

Reviewers:
cpu_(ooo_6.6-7.5), sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Added support in Metro mode for retrieving the information about the currently displayed tab url and title. This is retrieved via a registered window message sent by the metro driver. The information is used by the share charm in metro. BUG=125673 R=cpu,sky

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -6 lines)			Patch
M	chrome/browser/ui/views/frame/browser_frame_win.h	View		1 chunk	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_frame_win.cc	View	1	6 chunks	+57 lines, -3 lines	0 comments	Download
M	chrome/common/chrome_constants.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/common/chrome_constants.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sky

https://chromiumcodereview.appspot.com/10291007/diff/1/chrome/browser/ui/views/frame/browser_frame_win.cc File chrome/browser/ui/views/frame/browser_frame_win.cc (right): https://chromiumcodereview.appspot.com/10291007/diff/1/chrome/browser/ui/views/frame/browser_frame_win.cc#newcode220 chrome/browser/ui/views/frame/browser_frame_win.cc:220: if (message == metro_navigation_search_message) { nit: no {} https://chromiumcodereview.appspot.com/10291007/diff/1/chrome/browser/ui/views/frame/browser_frame_win.cc#newcode394 ...

8 years, 7 months ago (2012-05-01 23:48:53 UTC) #2

ananta

8 years, 7 months ago (2012-05-01 23:57:47 UTC) #3

ananta

8 years, 7 months ago (2012-05-02 00:30:04 UTC) #4

On 2012/05/01 23:57:47, ananta wrote:
>
https://chromiumcodereview.appspot.com/10291007/diff/1/chrome/browser/ui/view...
> File chrome/browser/ui/views/frame/browser_frame_win.cc (right):
> 
>
https://chromiumcodereview.appspot.com/10291007/diff/1/chrome/browser/ui/view...
> chrome/browser/ui/views/frame/browser_frame_win.cc:220: if (message ==
> metro_navigation_search_message) {
> On 2012/05/01 23:48:53, sky wrote:
> > nit: no {}
> 
> Leaving this as is as this is a compound if statement.
> 
>
https://chromiumcodereview.appspot.com/10291007/diff/1/chrome/browser/ui/view...
> chrome/browser/ui/views/frame/browser_frame_win.cc:394: string16
> current_url(UTF8ToWide(current_tab->GetURL().spec()));
> On 2012/05/01 23:48:53, sky wrote:
> > 381-387 is the same as this. How about a helper function that does this?
> 
> Done. Added a function LocalAllocAndCopyString in an anonymous namespace in
this
> file.

I landed this change by mistake while trying to land another change. Reverted
the commit. Will upload a new CL. Sorry about that.

-Ananta

Expand Messages | Collapse Messages