Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: chrome/browser/chromeos/gdata/gdata_file_system.cc

Issue 10288006: gdata: Fix a bug that caused a crash when downloading files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/gdata/gdata_file_system.cc
diff --git a/chrome/browser/chromeos/gdata/gdata_file_system.cc b/chrome/browser/chromeos/gdata/gdata_file_system.cc
index ee92b9d2914ba5403ecbf5ec7518471911c88434..41159f7eb884d653f279f397cc1d310cc1cf374d 100644
--- a/chrome/browser/chromeos/gdata/gdata_file_system.cc
+++ b/chrome/browser/chromeos/gdata/gdata_file_system.cc
@@ -773,6 +773,10 @@ void RelayGetDownloadDataCallback(
const GetDownloadDataCallback& callback,
GDataErrorCode error,
scoped_ptr<std::string> download_data) {
+ // Unlike other callbacks, GetDownloadDataCallback is optional, hence it
+ // can be null here.
+ if (callback.is_null())
+ return;
relay_proxy->PostTask(
FROM_HERE,
base::Bind(callback, error, base::Passed(&download_data)));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698