Issue 10288006: gdata: Fix a bug that caused a crash when downloading files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10288006: gdata: Fix a bug that caused a crash when downloading files (Closed)

Created:
8 years, 7 months ago by satorux1

Modified:
8 years, 7 months ago

Reviewers:
achuithb, Ben Chan

CC:
chromium-reviews, achuith+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

gdata: Fix a bug that caused a crash when downloading files GetDownloadDataCallback parameter in GDataFileSystem::GetFileByPath() was optional hence a null callback was passed in many places, and the null callback was posted to a message loop without checking if it's null or not. BUG=chromium-os:30198 TEST=double clicking on an image file on gdata; copy-pasting from gdata to Downloads; both don't crash Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134808

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	chrome/browser/chromeos/gdata/gdata_file_system.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

lgtm. Thanks!

Expand Messages | Collapse Messages