Issue 10284008: Switch client to Pepper UDP API instead of Transport API.

Issue 10284008: Switch client to Pepper UDP API instead of Transport API. (Closed)

Created:
8 years, 7 months ago by Sergey Ulanov

Modified:
8 years, 7 months ago

Reviewers:
Wez

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Switch client to Pepper UDP API instead of Transport API. BUG=109630 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137487

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -14 lines)			Patch
M	remoting/client/chromoting_client.h	View		2 chunks	+6 lines, -1 line	0 comments	Download
M	remoting/client/chromoting_client.cc	View		3 chunks	+6 lines, -3 lines	0 comments	Download
M	remoting/client/plugin/chromoting_instance.cc	View	1	4 chunks	+12 lines, -2 lines	0 comments	Download
M	remoting/client/plugin/pepper_packet_socket_factory.cc	View	1 2 3	1 chunk	+5 lines, -1 line	0 comments	Download
M	remoting/protocol/connection_to_host.h	View	1	4 chunks	+2 lines, -2 lines	0 comments	Download
M	remoting/protocol/connection_to_host.cc	View	1	3 chunks	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Wez

Basically LGTM, but please don't land this before M20 is branched. http://codereview.chromium.org/10284008/diff/1/remoting/protocol/connection_to_host.cc File remoting/protocol/connection_to_host.cc (left): ...

8 years, 7 months ago (2012-05-02 22:32:33 UTC) #2

Sergey Ulanov

http://codereview.chromium.org/10284008/diff/1/remoting/protocol/connection_to_host.cc File remoting/protocol/connection_to_host.cc (left): http://codereview.chromium.org/10284008/diff/1/remoting/protocol/connection_to_host.cc#oldcode35 remoting/protocol/connection_to_host.cc:35: pp_instance_(pp_instance), On 2012/05/02 22:32:33, Wez wrote: > Ouch; isn't ...

8 years, 7 months ago (2012-05-11 19:39:35 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10284008/9001

8 years, 7 months ago (2012-05-11 20:27:09 UTC) #4

commit-bot: I haz the power

8 years, 7 months ago (2012-05-16 17:21:30 UTC) #6

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10284008/10011

Expand Messages | Collapse Messages