Issue 102833009: Redo "Dummy receiver optimization"

Issue 102833009: Redo "Dummy receiver optimization" (Closed)

Created:
7 years ago by sra1

Modified:
7 years ago

Reviewers:
ahe, floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Redo "Dummy receiver optimization" Work around Issue 15720 R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=31307

Patch Set 4 : #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+140 lines, -14 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/constants.dart	View		3 chunks	+29 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ir/ir_pickler.dart	View	1 2	2 chunks	+3 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/backend.dart	View	1 2	3 chunks	+36 lines, -5 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/constant_emitter.dart	View		2 chunks	+8 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/namer.dart	View		2 chunks	+9 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/interceptor_simplifier.dart	View	1 2	4 chunks	+48 lines, -4 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/nodes.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/compiler/dart2js/literal_map_test.dart	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://chromiumcodereview.appspot.com/102833009/diff/20001/sdk/lib/_internal/compiler/implementation/ssa/interceptor_simplifier.dart File sdk/lib/_internal/compiler/implementation/ssa/interceptor_simplifier.dart (right): https://chromiumcodereview.appspot.com/102833009/diff/20001/sdk/lib/_internal/compiler/implementation/ssa/interceptor_simplifier.dart#newcode257 sdk/lib/_internal/compiler/implementation/ssa/interceptor_simplifier.dart:257: List<HInstruction> users = node.usedBy.toList(); Add comment explaining that ...

7 years ago (2013-12-19 10:29:16 UTC) #2

ahe

7 years ago (2013-12-20 16:30:20 UTC) #4

Message was sent while issue was closed.

Regrettably, I have to revert this.

My changes to restore performance of tear-off closures and fix intercepted
methods are affected by this, and Florian and I agreed that the best short-term
solution is to revert this :-(

Cheers,
Peter

Expand Messages | Collapse Messages