Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: runtime/vm/parser.cc

Issue 10280007: Check upper bounds of type arguments when allocating objects of a generic type (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.cc ('k') | tests/language/generic_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser.cc
===================================================================
--- runtime/vm/parser.cc (revision 7210)
+++ runtime/vm/parser.cc (working copy)
@@ -7853,8 +7853,8 @@
// Compile the throw of a dynamic type error due to a bound error.
return ThrowTypeError(type_pos, type);
}
- // TODO(regis): If the type argument vector is not instantiated, we need to
- // verify in checked mode at runtime that it is within its declared bounds.
+ // If the type argument vector is not instantiated, we verify in checked
+ // mode at runtime that it is within its declared bounds.
new_object = new ConstructorCallNode(
new_pos, type_arguments, constructor, arguments);
}
« no previous file with comments | « runtime/vm/object.cc ('k') | tests/language/generic_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698