Check upper bounds of type arguments when allocating objects of a generic type

runtime/vm/flow_graph_compiler_x64.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_X64.
 #if defined(TARGET_ARCH_X64)
 
 #include "vm/flow_graph_compiler.h"
 
 #include "lib/error.h"
@@ skipping 300 matching lines @@
   Label is_assignable, runtime_call;
   __ cmpq(RAX, raw_null);
   __ j(EQUAL, &is_assignable);
 
   // Generate throw new TypeError() if the type is malformed.
   if (dst_type.IsMalformed()) {
     const Error& error = Error::Handle(dst_type.malformed_error());
     const String& error_message = String::ZoneHandle(
         String::NewSymbol(error.ToErrorCString()));
     __ PushObject(Object::ZoneHandle());  // Make room for the result.
-    const Immediate location =
-        Immediate(reinterpret_cast<int64_t>(Smi::New(token_index)));
-    __ pushq(location);  // Push the source location.
+    __ pushq(Immediate(Smi::RawValue(token_index)));  // Source location.
     __ pushq(RAX);  // Push the source object.
     __ PushObject(dst_name);  // Push the name of the destination.
     __ PushObject(error_message);
     GenerateCallRuntime(cid,
                         token_index,
                         try_index,
                         kMalformedTypeErrorRuntimeEntry);
     // We should never return here.
     __ int3();
 
     __ Bind(&is_assignable);  // For a null object.
     return;
   }
 
   // Generate inline type check, linking to runtime call if not assignable.
   GenerateInlineInstanceof(dst_type, &is_assignable, &runtime_call);
 
   __ Bind(&runtime_call);
   __ PushObject(Object::ZoneHandle());  // Make room for the result.
-  const Immediate location =
-      Immediate(reinterpret_cast<int64_t>(Smi::New(token_index)));
-  const Immediate cid_as_smi =
-      Immediate(reinterpret_cast<int64_t>(Smi::New(cid)));
-  __ pushq(location);  // Push the source location.
-  __ pushq(cid_as_smi);  // node-id.
+  __ pushq(Immediate(Smi::RawValue(token_index)));  // Source location.
+  __ pushq(Immediate(Smi::RawValue(cid)));  // Computation id.
   __ pushq(RAX);  // Push the source object.
   __ PushObject(dst_type);  // Push the type of the destination.
   if (!dst_type.IsInstantiated()) {
     __ pushq(RDX);  // Instantiator type arguments.
   } else {
     __ pushq(raw_null);  // Null instantiator.
   }
   __ PushObject(dst_name);  // Push the name of the destination.
   GenerateCallRuntime(cid,
                       token_index,
@@ skipping 55 matching lines @@
 void FlowGraphCompiler::VisitAssertBoolean(AssertBooleanComp* comp) {
   LoadValue(RAX, comp->value());
   // Check that the type of the value is allowed in conditional context.
   // Call the runtime if the object is not bool::true or bool::false.
   Label done;
   __ CompareObject(RAX, Bool::ZoneHandle(Bool::True()));
   __ j(EQUAL, &done, Assembler::kNearJump);
   __ CompareObject(RAX, Bool::ZoneHandle(Bool::False()));
   __ j(EQUAL, &done, Assembler::kNearJump);
 
-  const Immediate location =
-      Immediate(reinterpret_cast<int64_t>(Smi::New(comp->token_index())));
-  __ pushq(location);  // Push the source location.
+  __ pushq(Immediate(Smi::RawValue(comp->token_index())));  // Source location.
   __ pushq(RAX);  // Push the source object.
   GenerateCallRuntime(comp->cid(),
                       comp->token_index(),
                       comp->try_index(),
                       kConditionTypeErrorRuntimeEntry);
   // We should never return here.
   __ int3();
 
   __ Bind(&done);
 }
@@ skipping 398 matching lines @@
     // Dynamic at run time.
     __ cmpq(RAX, raw_null);
     __ j(EQUAL, &is_not_instance);
   }
 
   // Generate inline instanceof test.
   GenerateInlineInstanceof(type, &is_instance, &is_not_instance);
 
   // Generate runtime call.
   __ PushObject(Object::ZoneHandle());  // Make room for the result.
-  const Immediate location =
-      Immediate(reinterpret_cast<int64_t>(Smi::New(token_index)));
-  const Immediate cid_as_smi =
-      Immediate(reinterpret_cast<int64_t>(Smi::New(cid)));
-  __ pushq(location);  // Push the source location.
-  __ pushq(cid_as_smi);
+  __ pushq(Immediate(Smi::RawValue(token_index)));  // Source location.
+  __ pushq(Immediate(Smi::RawValue(cid)));  // Computation id.
   __ pushq(RAX);  // Push the instance.
   __ PushObject(type);  // Push the type.
   if (!type.IsInstantiated()) {
     __ pushq(RDX);  // Instantiator type arguments.
   } else {
     __ pushq(raw_null);  // Null instantiator.
   }
   GenerateCallRuntime(cid, token_index, try_index, kInstanceofRuntimeEntry);
   // Pop the two parameters supplied to the runtime entry. The result of the
   // instanceof runtime call will be left as the result of the operation.
@@ skipping 38 matching lines @@
   const Code& stub = Code::Handle(StubCode::GetAllocationStubForClass(cls));
   const ExternalLabel label(cls.ToCString(), stub.EntryPoint());
   GenerateCall(comp->token_index(), comp->try_index(), &label,
                PcDescriptors::kOther);
   for (intptr_t i = 0; i < comp->arguments().length(); i++) {
     __ popq(RCX);  // Discard allocation argument
   }
 }
 
 
+void FlowGraphCompiler::VisitAllocateObjectWithBoundsCheck(
+    AllocateObjectWithBoundsCheckComp* comp) {
+  const Class& cls = Class::ZoneHandle(comp->constructor().owner());
+  __ popq(RCX);  // Pop instantiator type arguments.
+  __ popq(RAX);  // Pop type arguments.
+
+  // Push the result place holder initialized to NULL.
+  __ PushObject(Object::ZoneHandle());
+  __ pushq(Immediate(Smi::RawValue(comp->token_index())));
+  __ PushObject(cls);
+  __ pushq(RAX);  // Push type arguments.
+  __ pushq(RCX);  // Push instantiator type arguments.
+  GenerateCallRuntime(comp->cid(),
+                      comp->token_index(),
+                      comp->try_index(),
+                      kAllocateObjectWithBoundsCheckRuntimeEntry);
+  __ popq(RCX);  // Pop instantiator type arguments.
+  __ popq(RCX);  // Pop type arguments.
+  __ popq(RCX);  // Pop class.
+  __ popq(RCX);  // Pop source location.
+  __ popq(RAX);  // Pop new instance.
+}
+
+
 void FlowGraphCompiler::VisitCreateArray(CreateArrayComp* comp) {
   // 1. Allocate the array.  R10 = length, RBX = element type.
   __ movq(R10, Immediate(Smi::RawValue(comp->ElementCount())));
   const AbstractTypeArguments& element_type = comp->type_arguments();
   ASSERT(element_type.IsNull() || element_type.IsInstantiated());
   __ LoadObject(RBX, element_type);
   GenerateCall(comp->token_index(),
                comp->try_index(),
                &StubCode::AllocateArrayLabel(),
                PcDescriptors::kOther);
@@ skipping 54 matching lines @@
   // Instantiate non-null type arguments.
   if (comp->type_arguments().IsUninstantiatedIdentity()) {
     Label type_arguments_uninstantiated;
     // Check if the instantiator type argument vector is a TypeArguments of a
     // matching length and, if so, use it as the instantiated type_arguments.
     // No need to check the instantiator (RAX) for null here, because a null
     // instantiator will have the wrong class (Null instead of TypeArguments).
     __ LoadObject(RCX, Class::ZoneHandle(Object::type_arguments_class()));
     __ cmpq(RCX, FieldAddress(RAX, Object::class_offset()));
     __ j(NOT_EQUAL, &type_arguments_uninstantiated, Assembler::kNearJump);
-    Immediate arguments_length = Immediate(reinterpret_cast<int64_t>(
-        Smi::New(comp->type_arguments().Length())));
+    Immediate arguments_length =
+        Immediate(Smi::RawValue(comp->type_arguments().Length()));
     __ cmpq(FieldAddress(RAX, TypeArguments::length_offset()),
         arguments_length);
     __ j(EQUAL, &type_arguments_instantiated, Assembler::kNearJump);
     __ Bind(&type_arguments_uninstantiated);
   }
   // A runtime call to instantiate the type arguments is required before
   // calling the factory.
   __ PushObject(Object::ZoneHandle());  // Make room for the result.
   __ PushObject(comp->type_arguments());
   __ pushq(RAX);  // Push instantiator type arguments.
@@ skipping 28 matching lines @@
   // Instantiate non-null type arguments.
   if (comp->type_arguments().IsUninstantiatedIdentity()) {
     // Check if the instantiator type argument vector is a TypeArguments of a
     // matching length and, if so, use it as the instantiated type_arguments.
     // No need to check the instantiator (RAX) for null here, because a null
     // instantiator will have the wrong class (Null instead of TypeArguments).
     Label type_arguments_uninstantiated;
     __ LoadObject(RCX, Class::ZoneHandle(Object::type_arguments_class()));
     __ cmpq(RCX, FieldAddress(RAX, Object::class_offset()));
     __ j(NOT_EQUAL, &type_arguments_uninstantiated, Assembler::kNearJump);
-    Immediate arguments_length = Immediate(reinterpret_cast<int64_t>(
-        Smi::New(comp->type_arguments().Length())));
+    Immediate arguments_length =
+        Immediate(Smi::RawValue(comp->type_arguments().Length()));
     __ cmpq(FieldAddress(RAX, TypeArguments::length_offset()),
         arguments_length);
     __ j(EQUAL, &type_arguments_instantiated, Assembler::kNearJump);
     __ Bind(&type_arguments_uninstantiated);
   }
   // In the non-factory case, we rely on the allocation stub to
   // instantiate the type arguments.
   __ LoadObject(RAX, comp->type_arguments());
   // RAX: uninstantiated type arguments.
   __ Bind(&type_arguments_instantiated);
@@ skipping 34 matching lines @@
     // TODO(regis): This code will still change, because bounds checking is not
     // implemented yet.
 
     // Check if the instantiator type argument vector is a TypeArguments of a
     // matching length and, if so, use it as the instantiated type_arguments.
     // No need to check the instantiator (RAX) for null here, because a null
     // instantiator will have the wrong class (Null instead of TypeArguments).
     __ LoadObject(RCX, Class::ZoneHandle(Object::type_arguments_class()));
     __ cmpq(RCX, FieldAddress(RAX, Object::class_offset()));
     __ j(NOT_EQUAL, &done, Assembler::kNearJump);
-    Immediate arguments_length = Immediate(reinterpret_cast<int64_t>(
-        Smi::New(comp->type_arguments().Length())));
+    Immediate arguments_length =
+        Immediate(Smi::RawValue(comp->type_arguments().Length()));
     __ cmpq(FieldAddress(RAX, TypeArguments::length_offset()),
         arguments_length);
     __ j(NOT_EQUAL, &done, Assembler::kNearJump);
     // The instantiator was used in VisitExtractConstructorTypeArguments as the
     // instantiated type arguments, no proper instantiator needed.
     __ movq(RAX, Immediate(Smi::RawValue(StubCode::kNoInstantiator)));
   }
   __ Bind(&done);
   // RAX: instantiator or kNoInstantiator.
 }
@@ skipping 613 matching lines @@
   ASSERT(exception_handlers_list_ != NULL);
   const ExceptionHandlers& handlers = ExceptionHandlers::Handle(
       exception_handlers_list_->FinalizeExceptionHandlers(code.EntryPoint()));
   code.set_exception_handlers(handlers);
 }
 
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_X64