Check upper bounds of type arguments when allocating objects of a generic type

runtime/vm/code_generator_ia32.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_IA32.
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/code_generator.h"
 
 #include "lib/error.h"
@@ skipping 1169 matching lines @@
 
 
 void CodeGenerator::VisitIncrOpLocalNode(IncrOpLocalNode* node) {
   ASSERT((node->kind() == Token::kINCR) || (node->kind() == Token::kDECR));
   MarkDeoptPoint(node->id(), node->token_index());
   GenerateLoadVariable(EAX, node->local());
   if (!node->prefix() && IsResultNeeded(node)) {
     // Preserve as result.
     __ pushl(EAX);
   }
-  const Immediate value = Immediate(reinterpret_cast<int32_t>(Smi::New(1)));
   const char* operator_name = (node->kind() == Token::kINCR) ? "+" : "-";
   __ pushl(EAX);
-  __ pushl(value);
+  __ pushl(Immediate(Smi::RawValue(1)));
   GenerateBinaryOperatorCall(node->id(), node->token_index(), operator_name);
   // result is in EAX.
   if (FLAG_enable_type_checks) {
     GenerateAssertAssignable(node->id(),
                              node->token_index(),
                              NULL,
                              node->local().type(),
                              node->local().name());
   }
   GenerateStoreVariable(node->local(), EAX, EDX);
@@ skipping 11 matching lines @@
   MarkDeoptPoint(node->getter_id(), node->token_index());
   GenerateInstanceGetterCall(node->getter_id(),
                              node->token_index(),
                              node->field_name());
   // result is in EAX.
   __ popl(EDX);   // Get receiver.
   if (!node->prefix() && IsResultNeeded(node)) {
     // Preserve as result.
     __ pushl(EAX);  // Preserve value as result.
   }
-  const Immediate one_value = Immediate(reinterpret_cast<int32_t>(Smi::New(1)));
   const char* operator_name = (node->kind() == Token::kINCR) ? "+" : "-";
   // EAX: Value.
   // EDX: Receiver.
   __ pushl(EDX);  // Preserve receiver.
   __ pushl(EAX);  // Left operand.
-  __ pushl(one_value);  // Right operand.
+  __ pushl(Immediate(Smi::RawValue(1)));  // Right operand.
   GenerateBinaryOperatorCall(node->operator_id(),
                              node->token_index(),
                              operator_name);
   __ popl(EDX);  // Restore receiver.
   if (IsResultNeeded(node) && node->prefix()) {
     // Value stored into field is the result.
     __ pushl(EAX);
   }
   __ pushl(EDX);  // Receiver.
   __ pushl(EAX);  // Value.
@@ skipping 16 matching lines @@
   GenerateLoadIndexed(node->load_id(), node->token_index());
   // Result is in EAX.
   if (!node->prefix() && IsResultNeeded(node)) {
     // Preserve EAX as result.
     __ popl(EDX);  // Preserved index -> EDX.
     __ popl(ECX);  // Preserved array -> ECX.
     __ pushl(EAX);  // Preserve original value from indexed load.
     __ pushl(ECX);  // Array.
     __ pushl(EDX);  // Index.
   }
-  const Immediate value = Immediate(reinterpret_cast<int32_t>(Smi::New(1)));
   const char* operator_name = (node->kind() == Token::kINCR) ? "+" : "-";
   __ pushl(EAX);    // Left operand.
-  __ pushl(value);  // Right operand.
+  __ pushl(Immediate(Smi::RawValue(1)));  // Right operand.
   GenerateBinaryOperatorCall(node->operator_id(),
                              node->token_index(),
                              operator_name);
   __ pushl(EAX);
   // TOS(0): value, TOS(1): index, TOS(2): array.
   GenerateStoreIndexed(node->store_id(),
                        node->token_index(),
                        node->prefix() && IsResultNeeded(node));
 }
 
@@ skipping 174 matching lines @@
     __ j(NOT_EQUAL, &non_null, Assembler::kNearJump);
     __ PushObject(negate_result ? bool_true : bool_false);
     __ jmp(&done);
     __ Bind(&non_null);
   }
 
   GenerateInlineInstanceof(node_id, token_index, type,
                            &is_instance_of, &is_not_instance_of);
 
   __ PushObject(Object::ZoneHandle());  // Make room for the result.
-  const Immediate location =
-      Immediate(reinterpret_cast<int32_t>(Smi::New(token_index)));
-  const Immediate node_id_as_smi =
-      Immediate(reinterpret_cast<int32_t>(Smi::New(node_id)));
+  const Immediate location = Immediate(Smi::RawValue(token_index));
+  const Immediate node_id_as_smi = Immediate(Smi::RawValue(node_id));
   __ pushl(location);  // Push the source location.
   __ pushl(node_id_as_smi);  // node-id.
   __ pushl(EAX);  // Push the instance.
   __ PushObject(type);  // Push the type.
   if (!type.IsInstantiated()) {
     GenerateInstantiatorTypeArguments(token_index);
   } else {
     __ pushl(raw_null);  // Null instantiator.
   }
   GenerateCallRuntime(node_id, token_index, kInstanceofRuntimeEntry);
@@ skipping 341 matching lines @@
   Label done, runtime_call;
   __ cmpl(EAX, raw_null);
   __ j(EQUAL, &done);
 
   // Generate throw new TypeError() if the type is malformed.
   if (dst_type.IsMalformed()) {
     const Error& error = Error::Handle(dst_type.malformed_error());
     const String& error_message = String::ZoneHandle(
         String::NewSymbol(error.ToErrorCString()));
     __ PushObject(Object::ZoneHandle());  // Make room for the result.
-    const Immediate location =
-        Immediate(reinterpret_cast<int32_t>(Smi::New(token_index)));
-    __ pushl(location);  // Push the source location.
+    __ pushl(Immediate(Smi::RawValue(token_index)));  // Source location.
     __ pushl(EAX);  // Push the source object.
     __ PushObject(dst_name);  // Push the name of the destination.
     __ PushObject(error_message);
     GenerateCallRuntime(node_id, token_index, kMalformedTypeErrorRuntimeEntry);
     // We should never return here.
     __ int3();
 
     __ Bind(&done);  // For a null object.
     return;
   }
 
   GenerateInlineInstanceof(node_id, token_index, dst_type,
                            &done, &runtime_call);
 
   __ Bind(&runtime_call);
   __ PushObject(Object::ZoneHandle());  // Make room for the result.
-  const Immediate location =
-      Immediate(reinterpret_cast<int32_t>(Smi::New(token_index)));
-  const Immediate node_id_as_smi =
-      Immediate(reinterpret_cast<int32_t>(Smi::New(node_id)));
-  __ pushl(location);  // Push the source location.
-  __ pushl(node_id_as_smi);  // node-id.
+  __ pushl(Immediate(Smi::RawValue(token_index)));  // Source location.
+  __ pushl(Immediate(Smi::RawValue(node_id)));  // node-id.
   __ pushl(EAX);  // Push the source object.
   __ PushObject(dst_type);  // Push the type of the destination.
   if (dst_type.IsInstantiated()) {
     __ pushl(raw_null);  // Null instantiator.
   } else {
     GenerateInstantiatorTypeArguments(token_index);
   }
   __ PushObject(dst_name);  // Push the name of the destination.
   GenerateCallRuntime(node_id, token_index, kTypeCheckRuntimeEntry);
   // Pop the parameters supplied to the runtime entry. The result of the
@@ skipping 45 matching lines @@
   // This check should pass if the receiver's class implements the interface
   // 'bool'. Check only class 'Bool' since it is the only legal implementation
   // of the interface 'bool'.
   const Class& bool_class =
       Class::ZoneHandle(Isolate::Current()->object_store()->bool_class());
   __ movl(ECX, FieldAddress(EAX, Object::class_offset()));
   __ CompareObject(ECX, bool_class);
   __ j(EQUAL, &done, Assembler::kNearJump);
 
   __ Bind(&runtime_call);
-  const Immediate location =
-      Immediate(reinterpret_cast<int32_t>(Smi::New(token_index)));
-  __ pushl(location);  // Push the source location.
+  __ pushl(Immediate(Smi::RawValue(token_index)));  // Source location.
   __ pushl(EAX);  // Push the source object.
   GenerateCallRuntime(node_id, token_index, kConditionTypeErrorRuntimeEntry);
   // We should never return here.
   __ int3();
 
   __ Bind(&done);
 }
 
 
 void CodeGenerator::VisitComparisonNode(ComparisonNode* node) {
@@ skipping 613 matching lines @@
     // Instantiate non-null type arguments.
     if (node->type_arguments().IsUninstantiatedIdentity()) {
       // Check if the instantiator type argument vector is a TypeArguments of a
       // matching length and, if so, use it as the instantiated type_arguments.
       // No need to check RAX for null (again), because a null instance will
       // have the wrong class (Null instead of TypeArguments).
       Label type_arguments_uninstantiated;
       __ LoadObject(ECX, Class::ZoneHandle(Object::type_arguments_class()));
       __ cmpl(ECX, FieldAddress(EAX, Object::class_offset()));
       __ j(NOT_EQUAL, &type_arguments_uninstantiated, Assembler::kNearJump);
-      Immediate arguments_length = Immediate(reinterpret_cast<int32_t>(
-          Smi::New(node->type_arguments().Length())));
+      Immediate arguments_length =
+          Immediate(Smi::RawValue(node->type_arguments().Length()));
       __ cmpl(FieldAddress(EAX, TypeArguments::length_offset()),
           arguments_length);
       __ j(EQUAL, &type_arguments_instantiated, Assembler::kNearJump);
       __ Bind(&type_arguments_uninstantiated);
     }
     if (node->constructor().IsFactory()) {
       // A runtime call to instantiate the type arguments is required before
       // calling the factory.
       __ PushObject(Object::ZoneHandle());  // Make room for the result.
       __ PushObject(node->type_arguments());
@@ skipping 45 matching lines @@
     }
     return;
   }
 
   const Class& cls = Class::ZoneHandle(node->constructor().owner());
   const bool requires_type_arguments = cls.HasTypeArguments();
   GenerateTypeArguments(node, requires_type_arguments);
 
   // If cls is parameterized, the type arguments and the instantiator's
   // type arguments are on the stack.
-  const Code& stub = Code::Handle(StubCode::GetAllocationStubForClass(cls));
-  const ExternalLabel label(cls.ToCString(), stub.EntryPoint());
-  GenerateCall(node->token_index(), &label, PcDescriptors::kOther);
-  if (requires_type_arguments) {
+  // In checked mode, if the type arguments are uninstantiated, they may need to
+  // be checked against declared bounds at run time.
+  Error& malformed_error = Error::Handle();
+  if (FLAG_enable_type_checks &&
+      requires_type_arguments &&
+      !node->type_arguments().IsNull() &&
+      !node->type_arguments().IsInstantiated() &&
+      !node->type_arguments().IsWithinBoundsOf(cls,
+                                               node->type_arguments(),
+                                               &malformed_error)) {
+    // The uninstantiated type arguments cannot be verified to be within their
+    // bounds at compile time, so verify them at runtime.
+    // Although the type arguments may be uninstantiated at compile time, they
+    // may represent the identity vector and may be replaced by the instantiated
+    // type arguments of the instantiator at run time.
+    __ popl(ECX);  // Pop instantiator type arguments.
+    __ popl(EAX);  // Pop type arguments.
+
+    // Push the result place holder initialized to NULL.
+    __ PushObject(Object::ZoneHandle());
+    __ pushl(Immediate(Smi::RawValue(node->token_index())));
+    __ PushObject(cls);
+    __ pushl(EAX);  // Push type arguments.
+    __ pushl(ECX);  // Push instantiator type arguments.
+    GenerateCallRuntime(node->id(),
+                        node->token_index(),
+                        kAllocateObjectWithBoundsCheckRuntimeEntry);
+    __ popl(ECX);  // Pop instantiator type arguments.
     __ popl(ECX);  // Pop type arguments.
-    __ popl(ECX);  // Pop instantiator type arguments.
+    __ popl(ECX);  // Pop class.
+    __ popl(ECX);  // Pop source location.
+    __ popl(EAX);  // Pop new instance.
+  } else {
+    const Code& stub = Code::Handle(StubCode::GetAllocationStubForClass(cls));
+    const ExternalLabel label(cls.ToCString(), stub.EntryPoint());
+    GenerateCall(node->token_index(), &label, PcDescriptors::kOther);
+    if (requires_type_arguments) {
+      __ popl(ECX);  // Pop instantiator type arguments.
+      __ popl(ECX);  // Pop type arguments.
+    }
   }
 
   if (IsResultNeeded(node)) {
     __ pushl(EAX);  // Set up return value from allocate.
   }
 
   // First argument(this) for constructor call which follows.
   __ pushl(EAX);
   // Second argument is the implicit construction phase parameter.
   // Run both the constructor initializer list and the constructor body.
@@ skipping 334 matching lines @@
   const Error& error = Error::Handle(
       Parser::FormatError(script, token_index, "Error", format, args));
   va_end(args);
   Isolate::Current()->long_jump_base()->Jump(1, error);
   UNREACHABLE();
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32