Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10279002: gdata: Remove a DCHECK that does not make sense. (Closed)

Created:
8 years, 7 months ago by satorux1
Modified:
8 years, 7 months ago
Reviewers:
achuithb, Ben Chan
CC:
chromium-reviews, achuith+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

gdata: Remove a DCHECK that does not make sense. This was introduced in crrev.com/134770 - DCHECK(entry || error != base::PLATFORM_FILE_OK); + DCHECK(error != base::PLATFORM_FILE_OK); The latter does not make sense, as we are mostly expecting error to be base::PLATFORM_FILE_OK. Besides, the read directory operation can fail for various reasons. BUG=chromium-os:30251 TEST=the DCHECK failure is gone with --enable-dcheck Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134784

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M chrome/browser/chromeos/gdata/gdata_file_system_proxy.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
satorux1
8 years, 7 months ago (2012-05-01 21:23:06 UTC) #1
Ben Chan
8 years, 7 months ago (2012-05-01 21:38:01 UTC) #2 
lgtm

Powered by Google App Engine
This is Rietveld 408576698