Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issue 10275002: Add support initiating navigations/search requests in Chrome metro mode via a registered (Closed)

Created:
8 years, 7 months ago by ananta
Modified:
8 years, 7 months ago
Reviewers:
cpu_(ooo_6.6-7.5), sky
CC:
chromium-reviews
Visibility:
Public.

Description

Add support initiating navigations/search requests in Chrome metro mode via a registered window message. This is done by overriding the WindowImpl::OnWndProc virtual function in the BrowserFrameWin class which subclasses the NativeWidgetWin instance for the browser frame. BUG=118641 R=sky,cpu Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134602

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -0 lines) Patch
M chrome/browser/ui/views/frame/browser_frame_win.h View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_win.cc View 1 2 5 chunks +62 lines, -0 lines 0 comments Download
M chrome/common/chrome_constants.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/chrome_constants.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ananta
8 years, 7 months ago (2012-04-30 19:42:22 UTC) #1
sky
LGTM https://chromiumcodereview.appspot.com/10275002/diff/7001/chrome/browser/ui/views/frame/browser_frame_win.cc File chrome/browser/ui/views/frame/browser_frame_win.cc (right): https://chromiumcodereview.appspot.com/10275002/diff/7001/chrome/browser/ui/views/frame/browser_frame_win.cc#newcode211 chrome/browser/ui/views/frame/browser_frame_win.cc:211: if (message == metro_navigation_search_message) { nit: no {} ...
8 years, 7 months ago (2012-04-30 20:45:40 UTC) #2
ananta
https://chromiumcodereview.appspot.com/10275002/diff/7001/chrome/browser/ui/views/frame/browser_frame_win.cc File chrome/browser/ui/views/frame/browser_frame_win.cc (right): https://chromiumcodereview.appspot.com/10275002/diff/7001/chrome/browser/ui/views/frame/browser_frame_win.cc#newcode211 chrome/browser/ui/views/frame/browser_frame_win.cc:211: if (message == metro_navigation_search_message) { On 2012/04/30 20:45:40, sky ...
8 years, 7 months ago (2012-04-30 20:58:41 UTC) #3
cpu_(ooo_6.6-7.5)
8 years, 7 months ago (2012-04-30 21:21:30 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698