Issue 10274026: Revert r134673 ""View website" instead of "View in Web Store""

Issue 10274026: Revert r134673 ""View website" instead of "View in Web Store"" (Closed)

Created:
8 years, 7 months ago by M-A Ruel

Modified:
8 years, 7 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert r134673 ""View website" instead of "View in Web Store"" It broke multiple browser_tests like ExtensionWebstorePrivateApiTest.InstallAccepted and ExtensionNoConfirmWebstorePrivateApiTest.InstallTheme on multiple OSes. TBR=estade@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134688

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -17 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	chrome/browser/resources/extensions/extension_list.js	View	1 chunk	+4 lines, -7 lines	0 comments	Download
M	chrome/browser/resources/extensions/extensions.html	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/extensions/extension_settings_handler.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/extension.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/extensions/extension_constants.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/extensions/extension_constants.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

Example 1: http://build.chromium.org/p/chromium/builders/Mac%2010.5%20Tests%20%28dbg%29%281%29/builds/17931/steps/browser_tests/logs/stdio Note: Google Test filter = ExtensionNoConfirmWebstorePrivateApiTest.InstallTheme [==========] Running 1 test from 1 ...

8 years, 7 months ago (2012-05-01 13:00:30 UTC) #1

Example 1:
http://build.chromium.org/p/chromium/builders/Mac%2010.5%20Tests%20%28dbg%29%...
Note: Google Test filter = ExtensionNoConfirmWebstorePrivateApiTest.InstallTheme
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from ExtensionNoConfirmWebstorePrivateApiTest, where
TypeParam =
[ RUN      ] ExtensionNoConfirmWebstorePrivateApiTest.InstallTheme
[1684:-1603913952:338043975283:FATAL:chrome_v8_context_set.cc(154)] Check
failed: false. Event validation error during management.onInstalled -- Error:
Invalid value for argument 1. Property 'homepageProvided': Unexpected property.
Backtrace:
  0   Chromium Framework                  0x2b1adccf ChromeMain + 46098047
  1   Chromium Framework                  0x2b1adc6b ChromeMain + 46097947
(...)


Example 2:
http://build.chromium.org/p/chromium/builders/XP%20Tests%20%28dbg%29%282%29/b...
Note: Google Test filter = ExtensionWebstorePrivateApiTest.InstallAccepted
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from ExtensionWebstorePrivateApiTest, where TypeParam =
[ RUN      ] ExtensionWebstorePrivateApiTest.InstallAccepted
[1016:3004:0430/220024:1627687:ERROR:external_registry_extension_loader_win.cc(84)]
Missing value path for key
Software\Google\Chrome\Extensions\jfmjfhklogoienhpfnppmbcbjfjnkonk.
[1016:1984:0430/220033:1636171:INFO:CONSOLE(20)] "Error during
webstorePrivate.completeInstall: enfkhcelefdadlmkffamgdlgplcionje does not match
a previous call to beginInstallWithManifest3", source: sendRequest (20)
[1016:1984:0430/220033:1636171:INFO:CONSOLE(95)] "[SUCCESS]
completeBeforeBegin", source: apitest (95)
[1016:1984:0430/220033:1636234:INFO:CONSOLE(20)] "Error during
webstorePrivate.beginInstallWithManifest3: Invalid id", source: sendRequest (20)
[1016:1984:0430/220033:1636234:INFO:CONSOLE(95)] "[SUCCESS] invalidID", source:
apitest (95)
[1016:1984:0430/220034:1637734:INFO:CONSOLE(20)] "Error during
webstorePrivate.beginInstallWithManifest3: Invalid manifest", source:
sendRequest (20)
[1016:1984:0430/220034:1637734:INFO:CONSOLE(95)] "[SUCCESS] missingVersion",
source: apitest (95)
[1016:1984:0430/220034:1637859:INFO:CONSOLE(51)] "img.onload called", source:
http://www.example.com:2743/files/extensions/api_test/scoped_dir_13355/websto...
(51)
[0430/220104:ERROR:test_launcher.cc(384)] Test timeout (45000 ms) exceeded for
ExtensionWebstorePrivateApiTest.InstallAccepted

lgtm

Expand Messages | Collapse Messages