gdata: Add GDataFileSystem::GetEntryByPathAsync()

gdata: Add GDataFileSystem::GetEntryByPathAsync()

In preparation for making FindEntryByPathAsync() private.
The new function is not used in production code yet.

This function is needed as we get metadata of a file or
a directory in gdata_file_system_proxy.cc, without knowing
if the file path points to a file or a directory.

BUG=chromium-os:30251
TEST=add unit tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134727

[satorux1, 2012-05-01 06:52:01]

One more function to add. This should be the last one for this kind.

[achuithb, 2012-05-01 09:27:09]

http://codereview.chromium.org/10274025/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/gdata_file_system.cc (right):

http://codereview.chromium.org/10274025/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_file_system.cc:2141: void
GDataFileSystem::GetEntryInfoByPathAsync(
This is a lot of boiler plate copy and paste. Is there a way to templatize this?
We're adding quite a bit of code to this already large file, and so much of it
is repetitive.

[satorux1, 2012-05-01 16:50:41]

http://codereview.chromium.org/10274025/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/gdata_file_system.cc (right):

http://codereview.chromium.org/10274025/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_file_system.cc:2141: void
GDataFileSystem::GetEntryInfoByPathAsync(
On 2012/05/01 09:27:09, achuith.bhandarkar wrote:
> This is a lot of boiler plate copy and paste. Is there a way to templatize
this?
> We're adding quite a bit of code to this already large file, and so much of it
> is repetitive.

I totally agree with you that the code is overly repetitive. I originally tried
to consolidate boiler plate but I wasn't able to come up with a good way to do
it.

One idea is to hide GDataFileSystem class into the .cc file (which you suggested
before IIRC) so we can templatize functions aggressively, without worrying about
putting lots of code in .h file, but this will be a large change, so I'd do it
at a later time. I'll file a cleanup bug on this.

[achuithb, 2012-05-01 18:12:35]

lgtm