Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1056)

Unified Diff: chrome/browser/autocomplete/search_provider.h

Issue 10274023: Omnibox SearchProvider Experiment Client Implementation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixes and cleanup. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/search_provider.h
diff --git a/chrome/browser/autocomplete/search_provider.h b/chrome/browser/autocomplete/search_provider.h
index eea935abce62f2e963aa366664c890fbf4a51504..da4f02aeb914210f326347bfe16ef778fe84c836 100644
--- a/chrome/browser/autocomplete/search_provider.h
+++ b/chrome/browser/autocomplete/search_provider.h
@@ -89,6 +89,7 @@ class SearchProvider : public AutocompleteProvider,
static const int kKeywordProviderURLFetcherID;
private:
+ FRIEND_TEST_ALL_PREFIXES(SearchProviderTest, SuggestRelevanceExperiment);
FRIEND_TEST_ALL_PREFIXES(SearchProviderTest, NavigationInline);
FRIEND_TEST_ALL_PREFIXES(SearchProviderTest, NavigationInlineSchemeSubstring);
FRIEND_TEST_ALL_PREFIXES(SearchProviderTest, NavigationInlineDomainClassify);
@@ -226,6 +227,17 @@ class SearchProvider : public AutocompleteProvider,
// Clears the current results.
void ClearResults();
+ // Remove results that cannot inline auto-complete the current input.
+ void RemoveStaleResults();
+ void RemoveStaleSuggestResults(SuggestResults* list, bool is_keyword);
+ void RemoveStaleNavigationResults(NavigationResults* list, bool is_keyword);
+
+ // Apply calculated relevance scores to the current results.
+ void ApplyCalculatedRelevance();
+ void ApplyCalculatedSuggestRelevance(SuggestResults* list, bool is_keyword);
+ void ApplyCalculatedNavigationRelevance(NavigationResults* list,
+ bool is_keyword);
+
// Creates a URLFetcher requesting suggest results from the specified
// |suggestions_url|. The caller owns the returned URLFetcher.
net::URLFetcher* CreateSuggestFetcher(
@@ -343,6 +355,13 @@ class SearchProvider : public AutocompleteProvider,
NavigationResults keyword_navigation_results_;
NavigationResults default_navigation_results_;
+ // A flag indicating use of server supplied relevance scores.
+ bool has_suggested_relevance_;
+
+ // The suggested relevance for the verbatim result.
+ bool has_verbatim_relevance_;
Peter Kasting 2012/06/05 00:47:51 Nit: You could eliminate this and substitute with
msw 2012/06/05 01:49:41 Done.
+ int verbatim_relevance_;
+
// Whether suggest_results_ is valid.
bool have_suggest_results_;

Powered by Google App Engine
This is Rietveld 408576698