chrome/browser/autocomplete/autocomplete.cc - Issue 10274023: Omnibox SearchProvider Experiment Client Implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autocomplete/autocomplete.cc

Issue 10274023: Omnibox SearchProvider Experiment Client Implementation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Inline-autocomplete NavigationResults; cleanup and refactor. Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/autocomplete/autocomplete.cc

diff --git a/chrome/browser/autocomplete/autocomplete.cc b/chrome/browser/autocomplete/autocomplete.cc

index 8b4f9f74999ce7b44af73375f5ef91c20315a4e5..f72622d2088008e0024158d10ca3611a5998d20d 100644

--- a/chrome/browser/autocomplete/autocomplete.cc

+++ b/chrome/browser/autocomplete/autocomplete.cc

@@ -1007,8 +1007,8 @@ void AutocompleteController::UpdateResult(bool is_synchronous_pass) {

#endif

if (!done_) {

- // This conditional needs to match the conditional in Start that invokes

- // StartExpireTimer.

+ // This must match the conditional in Start that invokes StartExpireTimer.

+ // TODO(msw): Remove or sanitize copied SEARCH_SUGGEST matches?

result_.CopyOldMatches(input_, last_result);

}