chrome/browser/autocomplete/autocomplete_edit.cc - Issue 10274023: Omnibox SearchProvider Experiment Client Implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autocomplete/autocomplete_edit.cc

Issue 10274023: Omnibox SearchProvider Experiment Client Implementation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Working to some degree... Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/autocomplete/autocomplete_edit.cc

diff --git a/chrome/browser/autocomplete/autocomplete_edit.cc b/chrome/browser/autocomplete/autocomplete_edit.cc

index 58ea5633f4db152409db3385713857c0abc1c65c..b807ba42f6f0ea8d5f07618b959d816a471490ee 100644

--- a/chrome/browser/autocomplete/autocomplete_edit.cc

+++ b/chrome/browser/autocomplete/autocomplete_edit.cc

@@ -901,7 +901,8 @@ void AutocompleteEditModel::PopupBoundsChangedTo(const gfx::Rect& bounds) {

void AutocompleteEditModel::OnResultChanged(bool default_match_changed) {

const bool was_open = popup_->IsOpen();

- if (default_match_changed) {

+ // TODO(msw): Run this in all cases, or fixup default_match_changed?

Peter Kasting 2012/05/04 00:11:33 Shouldn't need to touch this, I wouldn't think.

msw 2012/05/04 09:43:40 Reverted.

+ static bool msw = true; if (msw || default_match_changed) {

string16 inline_autocomplete_text;

string16 keyword;

bool is_keyword_hint = false;