Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Unified Diff: remoting/webapp/host_setup_dialog.js

Issue 10274022: Added extra text to 'host started' dialog. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removed tab. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/webapp/_locales/en/messages.json ('k') | remoting/webapp/main.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/webapp/host_setup_dialog.js
diff --git a/remoting/webapp/host_setup_dialog.js b/remoting/webapp/host_setup_dialog.js
index 8bee46614b0ddfcc23e3f8d4e3bc2475e2f1bc16..3b24caf0ffa16af86828f09883e265e215122540 100644
--- a/remoting/webapp/host_setup_dialog.js
+++ b/remoting/webapp/host_setup_dialog.js
@@ -219,10 +219,17 @@ remoting.HostSetupDialog.prototype.updateState_ = function() {
l10n.localizeElementFromTag(messageDiv, tag);
remoting.setMode(remoting.AppMode.HOST_SETUP_PROCESSING);
}
- /** @param {string} tag */
- function showDoneMessage(tag) {
+ /** @param {string} tag1
+ * @param {string=} opt_tag2 */
+ function showDoneMessage(tag1, opt_tag2) {
var messageDiv = document.getElementById('host-setup-done-message');
- l10n.localizeElementFromTag(messageDiv, tag);
+ l10n.localizeElementFromTag(messageDiv, tag1);
+ messageDiv = document.getElementById('host-setup-done-message-2');
+ if (opt_tag2) {
+ l10n.localizeElementFromTag(messageDiv, opt_tag2);
+ } else {
+ messageDiv.innerHTML = '';
+ }
remoting.setMode(remoting.AppMode.HOST_SETUP_DONE);
}
/** @param {string} tag */
@@ -251,7 +258,8 @@ remoting.HostSetupDialog.prototype.updateState_ = function() {
showProcessingMessage(/*i18n-content*/'HOST_SETUP_STOPPING');
this.stopHost_();
} else if (state == remoting.HostSetupFlow.State.HOST_STARTED) {
- showDoneMessage(/*i18n-content*/'HOST_SETUP_STARTED');
+ showDoneMessage(/*i18n-content*/'HOST_SETUP_STARTED',
+ /*i18n-content*/'HOST_SETUP_STARTED_DISABLE_SLEEP');
Sergey Ulanov 2012/05/01 01:16:32 Potentially the host plugin could verify power set
Sergey Ulanov 2012/05/01 01:16:32 Why can't this message be part of HOST_SETUP_START
Jamie 2012/05/01 01:35:23 That's a nice idea, but I don't think it's feasibl
Jamie 2012/05/01 01:35:23 Firstly, I try to avoid putting HTML in translated
} else if (state == remoting.HostSetupFlow.State.UPDATED_PIN) {
showDoneMessage(/*i18n-content*/'HOST_SETUP_UPDATED_PIN');
} else if (state == remoting.HostSetupFlow.State.HOST_STOPPED) {
« no previous file with comments | « remoting/webapp/_locales/en/messages.json ('k') | remoting/webapp/main.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698