Added extra text to 'host started' dialog.

remoting/webapp/host_setup_dialog.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /** @suppress {duplicate} */
 var remoting = remoting || {};
 
 /**
@@ skipping 201 matching lines @@
  */
 remoting.HostSetupDialog.prototype.updateState_ = function() {
   remoting.hostController.updateDom();
 
   /** @param {string} tag */
   function showProcessingMessage(tag) {
     var messageDiv = document.getElementById('host-setup-processing-message');
     l10n.localizeElementFromTag(messageDiv, tag);
     remoting.setMode(remoting.AppMode.HOST_SETUP_PROCESSING);
   }
-  /** @param {string} tag */
-  function showDoneMessage(tag) {
+  /** @param {string} tag1
+   *  @param {string=} opt_tag2 */
+  function showDoneMessage(tag1, opt_tag2) {
     var messageDiv = document.getElementById('host-setup-done-message');
-    l10n.localizeElementFromTag(messageDiv, tag);
+    l10n.localizeElementFromTag(messageDiv, tag1);
+    messageDiv = document.getElementById('host-setup-done-message-2');
+    if (opt_tag2) {
+      l10n.localizeElementFromTag(messageDiv, opt_tag2);
+    } else {
+      messageDiv.innerHTML = '';
+    }
     remoting.setMode(remoting.AppMode.HOST_SETUP_DONE);
   }
   /** @param {string} tag */
   function showErrorMessage(tag) {
     var errorDiv = document.getElementById('host-setup-error-message');
     l10n.localizeElementFromTag(errorDiv, tag);
     remoting.setMode(remoting.AppMode.HOST_SETUP_ERROR);
   }
 
   var state = this.flow_.getState();
   if (state == remoting.HostSetupFlow.State.NONE) {
     this.hide();
   } else if (state == remoting.HostSetupFlow.State.ASK_PIN) {
     remoting.setMode(remoting.AppMode.HOST_SETUP_ASK_PIN);
   } else if (state == remoting.HostSetupFlow.State.INSTALL_HOST) {
     remoting.setMode(remoting.AppMode.HOST_SETUP_INSTALL);
     window.location =
         'http://dl.google.com/chrome-remote-desktop/chromeremotedesktop.dmg';
   } else if (state == remoting.HostSetupFlow.State.STARTING_HOST) {
     showProcessingMessage(/*i18n-content*/'HOST_SETUP_STARTING');
     this.startHost_();
   } else if (state == remoting.HostSetupFlow.State.UPDATING_PIN) {
     showProcessingMessage(/*i18n-content*/'HOST_SETUP_UPDATING_PIN');
     this.updatePin_();
   } else if (state == remoting.HostSetupFlow.State.STOPPING_HOST) {
     showProcessingMessage(/*i18n-content*/'HOST_SETUP_STOPPING');
     this.stopHost_();
   } else if (state == remoting.HostSetupFlow.State.HOST_STARTED) {
-    showDoneMessage(/*i18n-content*/'HOST_SETUP_STARTED');
+    showDoneMessage(/*i18n-content*/'HOST_SETUP_STARTED',
+                    /*i18n-content*/'HOST_SETUP_STARTED_DISABLE_SLEEP');

[Sergey Ulanov, 2012/05/01 01:16:32]

Potentially the host plugin could verify power settings, and then we could show
this message only when necessary.

[Sergey Ulanov, 2012/05/01 01:16:32]

Why can't this message be part of HOST_SETUP_STARTED? Is it just so that they
are separated visually? Then maybe we could just put <br> in that resource?

[Jamie, 2012/05/01 01:35:23]

That's a nice idea, but I don't think it's feasible for M20 in the time we have
left. I've added a TODO.

[Jamie, 2012/05/01 01:35:23]

Firstly, I try to avoid putting HTML in translated strings (although it's
occasionally necessary). Secondly, using a <br> to insert vertical space isn't
the right way to do it--we'd need separate <div>s for the two components as the
HTML currently has, which means that the string we send for translation becomes
quite complicated. Finally, if we ever did want to let the plugin control this
programmatically, it's a lot easier with two <div>s.

   } else if (state == remoting.HostSetupFlow.State.UPDATED_PIN) {
     showDoneMessage(/*i18n-content*/'HOST_SETUP_UPDATED_PIN');
   } else if (state == remoting.HostSetupFlow.State.HOST_STOPPED) {
     showDoneMessage(/*i18n-content*/'HOST_SETUP_STOPPED');
   } else if (state == remoting.HostSetupFlow.State.REGISTRATION_FAILED) {
     showErrorMessage(/*i18n-content*/'HOST_SETUP_REGISTRATION_FAILED');
   } else if (state == remoting.HostSetupFlow.State.START_HOST_FAILED) {
     showErrorMessage(/*i18n-content*/'HOST_SETUP_HOST_FAILED');
   } else if (state == remoting.HostSetupFlow.State.UPDATE_PIN_FAILED) {
     showErrorMessage(/*i18n-content*/'HOST_SETUP_UPDATE_PIN_FAILED');
@@ skipping 139 matching lines @@
 
 /**
  * @return {void} Nothing.
  */
 remoting.HostSetupDialog.prototype.onInstallDialogRetry = function() {
   remoting.setMode(remoting.AppMode.HOST_SETUP_INSTALL);
 }
 
 /** @type {remoting.HostSetupDialog} */
 remoting.hostSetupDialog = null;