Added extra text to 'host started' dialog.

Added extra text to 'host started' dialog.

BUG=125568
TEST=Manual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134665

[Jamie, 2012-05-01 00:15:14]

ptal

[Sergey Ulanov, 2012-05-01 01:16:32]

https://chromiumcodereview.appspot.com/10274022/diff/2001/remoting/webapp/hos...
File remoting/webapp/host_setup_dialog.js (right):

https://chromiumcodereview.appspot.com/10274022/diff/2001/remoting/webapp/hos...
remoting/webapp/host_setup_dialog.js:262:
/*i18n-content*/'HOST_SETUP_STARTED_DISABLE_SLEEP');
Potentially the host plugin could verify power settings, and then we could show
this message only when necessary.

https://chromiumcodereview.appspot.com/10274022/diff/2001/remoting/webapp/hos...
remoting/webapp/host_setup_dialog.js:262:
/*i18n-content*/'HOST_SETUP_STARTED_DISABLE_SLEEP');
Why can't this message be part of HOST_SETUP_STARTED? Is it just so that they
are separated visually? Then maybe we could just put <br> in that resource?

[Jamie, 2012-05-01 01:35:23]

https://chromiumcodereview.appspot.com/10274022/diff/2001/remoting/webapp/hos...
File remoting/webapp/host_setup_dialog.js (right):

https://chromiumcodereview.appspot.com/10274022/diff/2001/remoting/webapp/hos...
remoting/webapp/host_setup_dialog.js:262:
/*i18n-content*/'HOST_SETUP_STARTED_DISABLE_SLEEP');
On 2012/05/01 01:16:32, sergeyu wrote:
> Potentially the host plugin could verify power settings, and then we could
show
> this message only when necessary.

That's a nice idea, but I don't think it's feasible for M20 in the time we have
left. I've added a TODO.

https://chromiumcodereview.appspot.com/10274022/diff/2001/remoting/webapp/hos...
remoting/webapp/host_setup_dialog.js:262:
/*i18n-content*/'HOST_SETUP_STARTED_DISABLE_SLEEP');
On 2012/05/01 01:16:32, sergeyu wrote:
> Why can't this message be part of HOST_SETUP_STARTED? Is it just so that they
> are separated visually? Then maybe we could just put <br> in that resource?

Firstly, I try to avoid putting HTML in translated strings (although it's
occasionally necessary). Secondly, using a <br> to insert vertical space isn't
the right way to do it--we'd need separate <div>s for the two components as the
HTML currently has, which means that the string we send for translation becomes
quite complicated. Finally, if we ever did want to let the plugin control this
programmatically, it's a lot easier with two <div>s.

[Sergey Ulanov, 2012-05-01 01:45:38]

lgtm