Issue 10274020: Revert 134620 - Show a replacement plug-in for loading errors.

Issue 10274020: Revert 134620 - Show a replacement plug-in for loading errors. (Closed)

Created:
8 years, 7 months ago by Zhenyao Mo

Modified:
8 years, 7 months ago

Reviewers:
Bernhard Bauer

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, pam+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 134620 - Show a replacement plug-in for loading errors. Below are a few tests that are crashing (the list is not complete): compositing/plugins/composited-plugin.html compositing/plugins/1x1-composited-plugin.html compositing/plugins/small-to-large-composited-plugin.html compositing/plugins/large-to-small-composited-plugin.html This allows us to show a nicer placeholder when loading a plug-in fails then the one coming from WebKit. BUG=123580 TEST=manual Review URL: http://codereview.chromium.org/10093011 TBR=bauerb@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134630

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -151 lines)			Patch
MM	chrome/renderer/chrome_content_renderer_client.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
MM	chrome/renderer/chrome_content_renderer_client.cc	View	1 chunk	+0 lines, -8 lines	0 comments	Download
MM	chrome/renderer/plugins/plugin_placeholder.h	View	2 chunks	+1 line, -5 lines	0 comments	Download
MM	chrome/renderer/plugins/plugin_placeholder.cc	View	3 chunks	+0 lines, -24 lines	0 comments	Download
MM	content/public/renderer/content_renderer_client.h	View	3 chunks	+0 lines, -8 lines	0 comments	Download
M	content/renderer/mock_content_renderer_client.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	content/renderer/mock_content_renderer_client.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	content/renderer/pepper/pepper_plugin_delegate_impl.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	content/renderer/pepper/pepper_plugin_delegate_impl.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	content/renderer/render_view_impl.h	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	content/renderer/render_view_impl.cc	View	2 chunks	+0 lines, -17 lines	0 comments	Download
M	content/shell/shell_content_renderer_client.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	content/shell/shell_content_renderer_client.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	webkit/plugins/npapi/webplugin_impl.cc	View	2 chunks	+4 lines, -9 lines	0 comments	Download
M	webkit/plugins/npapi/webplugin_page_delegate.h	View	3 chunks	+1 line, -6 lines	0 comments	Download
M	webkit/plugins/ppapi/mock_plugin_delegate.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/plugins/ppapi/mock_plugin_delegate.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	webkit/plugins/ppapi/plugin_delegate.h	View	3 chunks	+2 lines, -8 lines	0 comments	Download
M	webkit/plugins/ppapi/ppapi_webplugin_impl.cc	View	2 chunks	+1 line, -10 lines	0 comments	Download
M	webkit/support/test_webplugin_page_delegate.h	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	webkit/support/test_webplugin_page_delegate.cc	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages