Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 10274014: Merge 114574 - REGRESSION(102040): Auto-table layout with percent width doesn't shrink-to-fit conte… (Closed)

Created:
8 years, 7 months ago by Julien - ping for review
Modified:
8 years, 7 months ago
Reviewers:
jchaffraix
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1084/
Visibility:
Public.

Description

Merge 114574 - REGRESSION(102040): Auto-table layout with percent width doesn't shrink-to-fit content a cell with colspan https://bugs.webkit.org/show_bug.cgi?id=84260 Reviewed by Ojan Vafai. Source/WebCore: Tests: fast/table/td-width-fifty-percent-regression-expected.html fast/table/td-width-fifty-percent-regression.html * rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::calcEffectiveLogicalWidth): As we are spreading the cell's min / max logical width, we should be updating them. This prevents the following logic getting confused and allocating more than needed. LayoutTests: * fast/table/td-width-fifty-percent-regression-expected.html: Added. * fast/table/td-width-fifty-percent-regression.html: Added. TBR=jchaffraix@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=115667

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
A + LayoutTests/fast/table/td-width-fifty-percent-regression.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/table/td-width-fifty-percent-regression-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/rendering/AutoTableLayout.cpp View 1 chunk +12 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Julien - ping for review
8 years, 7 months ago (2012-04-30 21:14:06 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698