Issue 10274007: Revert 134480 - Revert 134428 - GpuMemoryManager suggests values for renderer Contents Texture Mana…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10274007: Revert 134480 - Revert 134428 - GpuMemoryManager suggests values for renderer Contents Texture Mana… (Closed)

Created:
8 years, 7 months ago by mmocny

Modified:
8 years, 7 months ago

Reviewers:
Nicolas Sylvain, nsylvain

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 134480 - Revert 134428 - GpuMemoryManager suggests values for renderer Contents Texture Managers' preferred memory limit. ======================================== This broke mac browser tests with "Failed to initialize command buffer service." broken tests:AudioLayoutTest.AudioOnlyVideoIntrinsicSize and AudioLayoutTest.MediaDocumentAudioSize BUG=123382 TEST=Manual Review URL: http://codereview.chromium.org/10083056 TBR=mmocny@chromium.org ======================================== This CL was not likely to be the cause and I just ran mac browser_tests without any issues. Review URL: https://chromiumcodereview.appspot.com/10267002 TBR=nsylvain@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134527

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+364 lines, -203 lines)			Patch
M	content/common/gpu/client/command_buffer_proxy_impl.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc	View	2 chunks	+8 lines, -4 lines	0 comments	Download
M	content/common/gpu/gpu_command_buffer_stub.h	View	4 chunks	+5 lines, -0 lines	0 comments	Download
M	content/common/gpu/gpu_command_buffer_stub.cc	View	4 chunks	+17 lines, -1 line	0 comments	Download
M	content/common/gpu/gpu_memory_allocation.h	View	2 chunks	+11 lines, -5 lines	0 comments	Download
M	content/common/gpu/gpu_memory_manager.h	View	1 chunk	+17 lines, -0 lines	0 comments	Download
M	content/common/gpu/gpu_memory_manager.cc	View	5 chunks	+67 lines, -38 lines	0 comments	Download
M	content/common/gpu/gpu_memory_manager_unittest.cc	View	13 chunks	+232 lines, -155 lines	0 comments	Download
M	content/common/gpu/gpu_messages.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

nsylvain

8 years, 7 months ago (2012-04-30 15:53:21 UTC) #2

lgtm

it was definitely the cause, but maybe because it did not build correctly on the
builder or something like that.  It started with your cl (only yours in the
blamelist), stayed red for a long time, and turn back green when i did the
revert, and stayed green.

But your revert looks good so far. let's keep an eye on it.

thanks

Expand Messages | Collapse Messages