Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Issue 10273030: Fix Bookmark manager DnD: WebDragDestinationDelegate was getting recreated with (Closed)

Created:
8 years, 7 months ago by varunjain
Modified:
8 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Fix Bookmark manager DnD: WebDragDestinationDelegate was getting recreated with every call to GetDragDestDelegate() destroying local state. BUG=123359 TEST=dnd works on bookmark manager Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134782

Patch Set 1 #

Total comments: 2

Patch Set 2 : patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -19 lines) Patch
M content/browser/web_contents/web_contents_view_aura.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 1 7 chunks +21 lines, -17 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
varunjain
8 years, 7 months ago (2012-05-01 16:59:39 UTC) #1
sky
https://chromiumcodereview.appspot.com/10273030/diff/1/content/browser/web_contents/web_contents_view_aura.cc File content/browser/web_contents/web_contents_view_aura.cc (right): https://chromiumcodereview.appspot.com/10273030/diff/1/content/browser/web_contents/web_contents_view_aura.cc#newcode217 content/browser/web_contents/web_contents_view_aura.cc:217: if (delegate_.get()) Add a comment as to why you're ...
8 years, 7 months ago (2012-05-01 17:33:51 UTC) #2
varunjain
https://chromiumcodereview.appspot.com/10273030/diff/1/content/browser/web_contents/web_contents_view_aura.cc File content/browser/web_contents/web_contents_view_aura.cc (right): https://chromiumcodereview.appspot.com/10273030/diff/1/content/browser/web_contents/web_contents_view_aura.cc#newcode217 content/browser/web_contents/web_contents_view_aura.cc:217: if (delegate_.get()) On 2012/05/01 17:33:51, sky wrote: > Add ...
8 years, 7 months ago (2012-05-01 17:56:35 UTC) #3
sky
LGTM
8 years, 7 months ago (2012-05-01 18:19:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varunjain@chromium.org/10273030/7001
8 years, 7 months ago (2012-05-01 19:09:59 UTC) #5
commit-bot: I haz the power
8 years, 7 months ago (2012-05-01 21:43:19 UTC) #6
Change committed as 134782

Powered by Google App Engine
This is Rietveld 408576698