Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 10273025: [OTS] Add lzma_sdk for standalone build (Closed)

Created:
8 years, 7 months ago by bashi
Modified:
8 years, 7 months ago
Reviewers:
Yusuke Sato, agl
CC:
chromium-reviews
Visibility:
Public.

Description

[OTS] Add lzma_sdk for standalone build Add lzma sdk 9.20 for standalone build. These are not used when OTS is compiled as a part of Chromium. BUG=chromium:122603 TEST=compiled

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5161 lines, -1 line) Patch
M ots-standalone.gyp View 2 chunks +4 lines, -1 line 0 comments Download
A third_party/lzma_sdk/Alloc.h View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/lzma_sdk/Alloc.c View 1 chunk +127 lines, -0 lines 0 comments Download
A third_party/lzma_sdk/LICENSE View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/lzma_sdk/LzFind.h View 1 chunk +115 lines, -0 lines 0 comments Download
A third_party/lzma_sdk/LzFind.c View 1 chunk +761 lines, -0 lines 0 comments Download
A third_party/lzma_sdk/LzHash.h View 1 chunk +54 lines, -0 lines 0 comments Download
A third_party/lzma_sdk/LzmaDec.h View 1 chunk +231 lines, -0 lines 0 comments Download
A third_party/lzma_sdk/LzmaDec.c View 1 chunk +999 lines, -0 lines 0 comments Download
A third_party/lzma_sdk/LzmaEnc.h View 1 chunk +80 lines, -0 lines 0 comments Download
A third_party/lzma_sdk/LzmaEnc.c View 1 chunk +2268 lines, -0 lines 0 comments Download
A third_party/lzma_sdk/LzmaLib.h View 1 chunk +135 lines, -0 lines 0 comments Download
A third_party/lzma_sdk/LzmaLib.c View 1 chunk +46 lines, -0 lines 0 comments Download
A third_party/lzma_sdk/README.ots View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/lzma_sdk/Types.h View 1 chunk +254 lines, -0 lines 0 comments Download
A third_party/lzma_sdk/lzma_sdk.gyp View 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bashi
Hi Yusuke-san, agl, (Previous review: http://codereview.chromium.org/10025017) I'd like to add lzma_sdk for standalone build so ...
8 years, 7 months ago (2012-05-01 04:55:56 UTC) #1
Yusuke Sato
lgtm On 2012/05/01 04:55:56, bashik wrote: > Hi Yusuke-san, agl, > > (Previous review: http://codereview.chromium.org/10025017) ...
8 years, 7 months ago (2012-05-01 05:07:39 UTC) #2
bashi
8 years, 7 months ago (2012-05-02 00:20:06 UTC) #3
Committed. Thanks!

On 2012/05/01 05:07:39, Yusuke Sato wrote:
> lgtm
> 
> On 2012/05/01 04:55:56, bashik wrote:
> > Hi Yusuke-san, agl,
> > 
> > (Previous review: http://codereview.chromium.org/10025017)
> > 
> > I'd like to add lzma_sdk for standalone build so that we can test the woff2
> > algorithm(http://code.google.com/p/font-compression-reference/) without
> chromium
> > tree. This lzma_sdk won't be used when we build OTS as a part of Chromium. I
> > didn't make any changes on lzma_sdk.
> > 
> > Files to review:
> > ots-standalone.gyp
> > third_party/lzma_sdk/LICENSE
> > third_party/lzma_sdk/README.ots
> > third_party/lzma_sdk/lzma_sdk.gyp

Powered by Google App Engine
This is Rietveld 408576698