Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 10273023: [Ash] Always show the root window (Closed)

Created:
8 years, 7 months ago by oshima
Modified:
8 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : move to parts #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -13 lines) Patch
M chrome/browser/chrome_browser_main.cc View 1 3 chunks +0 lines, -13 lines 0 comments Download
M chrome/browser/chrome_browser_main_extra_parts_ash.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
oshima
8 years, 7 months ago (2012-05-01 03:10:31 UTC) #1
sky
http://codereview.chromium.org/10273023/diff/1/chrome/browser/chrome_browser_main.cc File chrome/browser/chrome_browser_main.cc (right): http://codereview.chromium.org/10273023/diff/1/chrome/browser/chrome_browser_main.cc#newcode1898 chrome/browser/chrome_browser_main.cc:1898: #if defined(USE_ASH) If you need to move Show here, ...
8 years, 7 months ago (2012-05-01 15:43:27 UTC) #2
oshima
http://codereview.chromium.org/10273023/diff/1/chrome/browser/chrome_browser_main.cc File chrome/browser/chrome_browser_main.cc (right): http://codereview.chromium.org/10273023/diff/1/chrome/browser/chrome_browser_main.cc#newcode1898 chrome/browser/chrome_browser_main.cc:1898: #if defined(USE_ASH) On 2012/05/01 15:43:27, sky wrote: > If ...
8 years, 7 months ago (2012-05-01 16:25:33 UTC) #3
sky
Nice, LGTM
8 years, 7 months ago (2012-05-01 17:04:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/10273023/1003
8 years, 7 months ago (2012-05-01 17:14:32 UTC) #5
commit-bot: I haz the power
Change committed as 134740
8 years, 7 months ago (2012-05-01 18:59:10 UTC) #6
oshima
On 2012/05/01 18:59:10, I haz the power (commit-bot) wrote: > Change committed as 134740 Looks ...
8 years, 7 months ago (2012-05-01 20:55:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/10273023/7006
8 years, 7 months ago (2012-05-01 21:28:18 UTC) #8
commit-bot: I haz the power
Try job failure for 10273023-7006 (retry) on linux_rel for step "browser_tests". It's a second try, ...
8 years, 7 months ago (2012-05-01 22:37:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/10273023/7006
8 years, 7 months ago (2012-05-01 22:41:29 UTC) #10
commit-bot: I haz the power
8 years, 7 months ago (2012-05-01 22:53:48 UTC) #11
Try job failure for 10273023-7006 on win_rel for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

Powered by Google App Engine
This is Rietveld 408576698