Refactor the socket API to remove onEvent callback in socket.create() function.

chrome/browser/extensions/api/socket/tcp_socket_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/socket/tcp_socket.h"
 
 #include "base/memory/scoped_ptr.h"
 #include "chrome/browser/extensions/api/api_resource_event_notifier.h"
 #include "net/base/address_list.h"
 #include "net/base/completion_callback.h"
@@ skipping 35 matching lines @@
                                                             0, GURL()) {}
 
   MOCK_METHOD2(OnReadComplete, void(int result_code,
                                     const std::string& message));
   MOCK_METHOD1(OnWriteComplete, void(int result_code));
 
  protected:
   virtual ~MockAPIResourceEventNotifier() {}
 };
 
+class CompleteHandler {
+ public:
+  CompleteHandler() {}
+  MOCK_METHOD1(OnComplete, void(int result_code));
+  MOCK_METHOD2(OnReadComplete, void(int result_code,
+      scoped_refptr<net::IOBuffer> io_buffer));
+ private:
+  DISALLOW_COPY_AND_ASSIGN(CompleteHandler);
+};
+
+
 TEST(SocketTest, TestTCPSocketRead) {
   net::AddressList address_list;
   MockTCPSocket* tcp_client_socket = new MockTCPSocket(address_list);
   APIResourceEventNotifier* notifier = new MockAPIResourceEventNotifier();
+  CompleteHandler handler;
 
   scoped_ptr<TCPSocket> socket(TCPSocket::CreateSocketForTesting(
       tcp_client_socket, notifier));
 
   EXPECT_CALL(*tcp_client_socket, Read(_, _, _))
       .Times(1);
+  EXPECT_CALL(handler, OnReadComplete(_, _))
+      .Times(1);
 
-  scoped_refptr<net::IOBufferWithSize> io_buffer(
-      new net::IOBufferWithSize(512));
-  socket->Read(io_buffer.get(), io_buffer->size());
+  const int count = 512;
+  socket->Read(count, base::Bind(&CompleteHandler::OnReadComplete,
+        base::Unretained(&handler)));
 }
 
 TEST(SocketTest, TestTCPSocketWrite) {
   net::AddressList address_list;
   MockTCPSocket* tcp_client_socket = new MockTCPSocket(address_list);
   APIResourceEventNotifier* notifier = new MockAPIResourceEventNotifier();
+  CompleteHandler handler;
 
   scoped_ptr<TCPSocket> socket(TCPSocket::CreateSocketForTesting(
       tcp_client_socket, notifier));
 
   EXPECT_CALL(*tcp_client_socket, Write(_, _, _))
       .Times(1);
+  EXPECT_CALL(handler, OnComplete(_))
+      .Times(1);
 
   scoped_refptr<net::IOBufferWithSize> io_buffer(
       new net::IOBufferWithSize(256));
-  socket->Write(io_buffer.get(), io_buffer->size());
+  socket->Write(io_buffer.get(), io_buffer->size(),
+      base::Bind(&CompleteHandler::OnComplete, base::Unretained(&handler)));
 }
 
 TEST(SocketTest, TestTCPSocketBlockedWrite) {
   net::AddressList address_list;
   MockTCPSocket* tcp_client_socket = new MockTCPSocket(address_list);
   MockAPIResourceEventNotifier* notifier = new MockAPIResourceEventNotifier();
+  CompleteHandler handler;
 
   scoped_ptr<TCPSocket> socket(TCPSocket::CreateSocketForTesting(
       tcp_client_socket, notifier));
 
   net::CompletionCallback callback;
   EXPECT_CALL(*tcp_client_socket, Write(_, _, _))
       .Times(1)
       .WillOnce(testing::DoAll(SaveArg<2>(&callback),
                                Return(net::ERR_IO_PENDING)));
-
   scoped_refptr<net::IOBufferWithSize> io_buffer(new net::IOBufferWithSize(
       1));
-  ASSERT_EQ(net::ERR_IO_PENDING, socket->Write(io_buffer.get(),
-                                               io_buffer->size()));
+  socket->Write(io_buffer.get(), io_buffer->size(),
+      base::Bind(&CompleteHandler::OnComplete, base::Unretained(&handler)));
 
   // Good. Original call came back unable to complete. Now pretend the socket
   // finished, and confirm that we passed the error back.
-  EXPECT_CALL(*notifier, OnWriteComplete(42))
+  EXPECT_CALL(handler, OnComplete(42))
       .Times(1);
   callback.Run(42);
 }
 
 }  // namespace extensions