Issue 10273012: ash: Fix shelf auto hide behavior not persisted regression.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10273012: ash: Fix shelf auto hide behavior not persisted regression. (Closed)

Created:
8 years, 7 months ago by xiyuan

Modified:
8 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ash: Fix shelf auto hide behavior not persisted regression. Change LauncherContextMenu::ToggleAutoHideMenu to just return the toggled auto hide behavior and make the behavior change go through ChromeLauncherDelegate, which would persist the new behavior. Also removed no longer in use kAlwaysAutoHideShelf pref. BUG=124083 TEST=Verify fix for issue 124083. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134707

Patch Set 1 #

Patch Set 2 : rebase #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -14 lines)			Patch
M	ash/launcher/launcher_context_menu.h	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	ash/launcher/launcher_context_menu.cc	View	3 chunks	+4 lines, -3 lines	0 comments	Download
M	ash/launcher/launcher_context_menu_unittest.cc	View	1 chunk	+8 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/views/ash/launcher/launcher_context_menu.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/common/pref_names.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/pref_names.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

xiyuan

This change fix the broken link between pref and shelf auto hide behavior. I should ...

8 years, 7 months ago (2012-04-30 17:46:19 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/10273012/1

8 years, 7 months ago (2012-05-01 00:42:35 UTC) #3

commit-bot: I haz the power

8 years, 7 months ago (2012-05-01 00:55:24 UTC) #4

Try job failure for 10273012-1 on win_rel for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

Expand Messages | Collapse Messages