content/browser/speech/speech_recognition_manager_impl.h - Issue 10273006: Introduced SpeechRecognitionDispatcher(Host) classes, handling dispatch of IPC messages for continu…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/speech/speech_recognition_manager_impl.h

Issue 10273006: Introduced SpeechRecognitionDispatcher(Host) classes, handling dispatch of IPC messages for continu… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Satish review. Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/speech/speech_recognition_dispatcher_host.cc ('k') | content/browser/speech/speech_recognition_manager_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/speech/speech_recognition_manager_impl.h

diff --git a/content/browser/speech/speech_recognition_manager_impl.h b/content/browser/speech/speech_recognition_manager_impl.h

index 5aab48f1419ab3ffdd6bea8eb63ba5c4fa07465f..d0061aca3bc4cbf1766e4dc260a0fab27becae03 100644

--- a/content/browser/speech/speech_recognition_manager_impl.h

+++ b/content/browser/speech/speech_recognition_manager_impl.h

@@ -67,10 +67,9 @@ class CONTENT_EXPORT SpeechRecognitionManagerImpl :

int session_id) const OVERRIDE;

virtual content::SpeechRecognitionSessionContext GetSessionContext(

int session_id) const OVERRIDE;

- virtual int LookupSessionByContext(

- base::Callback<bool(

- const content::SpeechRecognitionSessionContext&)> matcher)

- const OVERRIDE;

+ virtual int LookupSessionByContext(int render_process_id,

Satish 2012/05/21 15:18:58 suggest renaming to 'GetSession' or 'GetSessionFor

Primiano Tucci (use gerrit) 2012/05/21 16:37:13 Done.

+ int render_view_id,

+ int request_id) const OVERRIDE;

virtual bool HasAudioInputDevices() OVERRIDE;

virtual bool IsCapturingAudio() OVERRIDE;

virtual string16 GetAudioInputDeviceModel() OVERRIDE;