Issue 10272035: [Mac] Give info bubble windows a gaussian blur and a smaller border radius.

Issue 10272035: [Mac] Give info bubble windows a gaussian blur and a smaller border radius. (Closed)

Created:
8 years, 7 months ago by Robert Sesek

Modified:
8 years, 5 months ago

Reviewers:
Nico

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Mac] Give info bubble windows a gaussian blur and a smaller border radius. BUG=none TEST=Visual. Bubbles look more up-to-date on later OSes. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134795

Patch Set 1 #

Total comments: 4

Patch Set 2 : _CGSDefaultConnection #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -7 lines)			Patch
M	chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller.mm	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/info_bubble_view.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/info_bubble_view.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/info_bubble_window.mm	View	1	3 chunks	+40 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Robert Sesek

Screen shot: http://cl.ly/0P3X3p2n3L0N2k1U122X. Already approved by chrome-ui.

8 years, 7 months ago (2012-05-01 19:56:06 UTC) #1

Nico

Pretty! https://chromiumcodereview.appspot.com/10272035/diff/1/chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller.mm File chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller.mm (right): https://chromiumcodereview.appspot.com/10272035/diff/1/chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller.mm#newcode470 chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller.mm:470: backgroundColor = [NSColor clearColor]; What does this paint? ...

8 years, 7 months ago (2012-05-01 20:02:41 UTC) #2

Robert Sesek

https://chromiumcodereview.appspot.com/10272035/diff/1/chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller.mm File chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller.mm (right): https://chromiumcodereview.appspot.com/10272035/diff/1/chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller.mm#newcode470 chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller.mm:470: backgroundColor = [NSColor clearColor]; On 2012/05/01 20:02:41, Nico wrote: ...

8 years, 7 months ago (2012-05-01 20:08:12 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/10272035/7001

8 years, 7 months ago (2012-05-01 20:24:06 UTC) #5

For posterity, this caused http://crbug.com/135382

Expand Messages | Collapse Messages