Issue 10272027: Tighten up the DEPS file in aura to prevent inclusion of higher level bits of ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10272027: Tighten up the DEPS file in aura to prevent inclusion of higher level bits of ui/ (Closed)

Created:
8 years, 7 months ago by Ben Goodger (Google)

Modified:
8 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Tighten up the DEPS file in aura to prevent inclusion of higher level bits of ui/ BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134713

Patch Set 2 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	ui/aura/DEPS	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sky

http://codereview.chromium.org/10272027/diff/1/ui/aura/DEPS File ui/aura/DEPS (right): http://codereview.chromium.org/10272027/diff/1/ui/aura/DEPS#newcode7 ui/aura/DEPS:7: "+ui/base", nit: you've got ui/base twice.

8 years, 7 months ago (2012-05-01 16:26:48 UTC) #2

LGTM

Expand Messages | Collapse Messages

Issue 10272027: Tighten up the DEPS file in aura to prevent inclusion of higher level bits of ui/ (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages