Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1399)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/disassembler_ia32.cc

Issue 10272017: Fix disassembler crash. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/disassembler_ia32.cc
===================================================================
--- runtime/vm/disassembler_ia32.cc (revision 7163)
+++ runtime/vm/disassembler_ia32.cc (working copy)
@@ -397,6 +397,7 @@
Print(addr_buffer);
// Try to print as heap object or stub name
if (!Isolate::Current()->heap()->CodeContains(addr) &&
+ !Isolate::Current()->heap()->StubCodeContains(addr - kHeapObjectTag) &&
siva 2012/04/30 20:45:21 could be just addr...
srdjan 2012/04/30 20:46:42 Done.
Isolate::Current()->heap()->Contains(addr - kHeapObjectTag)) {
Object& obj = Object::Handle(reinterpret_cast<RawObject*>(addr));
if (obj.IsArray()) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698