Issue 10271026: gdata: Add GDataFileSystem::ReadDirectoryByPathAsync()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10271026: gdata: Add GDataFileSystem::ReadDirectoryByPathAsync() (Closed)

Created:
8 years, 7 months ago by satorux1

Modified:
8 years, 7 months ago

Reviewers:
achuithb

CC:
chromium-reviews, achuith+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

gdata: Add GDataFileSystem::ReadDirectoryByPathAsync() In preparation for making FindEntryByPathAsync() private. The new function is not used in production code yet. BUG=chromium-os:30251 TEST=add unit tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134681

Patch Set 1 #

Patch Set 2 : polish #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+183 lines, -33 lines)			Patch
M	chrome/browser/chromeos/gdata/gdata_file_system.h	View	1	5 chunks	+35 lines, -7 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system.cc	View		4 chunks	+77 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc	View	1	14 chunks	+68 lines, -20 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/mock_gdata_file_system.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

achuithb

On 2012/05/01 00:18:15, achuith.bhandarkar wrote: > lgtm I'm assuming the code is the same as ...

8 years, 7 months ago (2012-05-01 00:18:46 UTC) #3

satorux1

8 years, 7 months ago (2012-05-01 01:06:49 UTC) #4

On 2012/05/01 00:18:46, achuith.bhandarkar wrote:
> On 2012/05/01 00:18:15, achuith.bhandarkar wrote:
> > lgtm
> 
> I'm assuming the code is the same as the file counterpart?

Yes. It's essentially the same. The code is rather redundant but the good thing
is it's type safe.

Expand Messages | Collapse Messages