Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 10271023: Move ChromeOS memory collection function from perf.py to pyauto.py. (Closed)

Created:
8 years, 7 months ago by dennis_jeffrey
Modified:
8 years, 7 months ago
Reviewers:
Nirnimesh
CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1, Nirnimesh, ilja, Sonny
Visibility:
Public.

Description

Move ChromeOS memory collection function from perf.py to pyauto.py. Also changed the name of the function from _GetMemoryStats to GetCrosMemoryStats. This change allows autotests (that import pyauto) to invoke the memory collection function using something like this: mem_info_dict = self.pyauto.GetMemoryStatsChromeOS(20) (except replace '20' with a suitable duration for the given test). BUG=None TEST=Verified that autotest graphics_WebGLPerformance can successfully invoke GetCrosMemoryStats(), given the change to pyauto.py in this CL. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134622

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comment from patch set 1. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -170 lines) Patch
M chrome/test/functional/perf.py View 1 2 chunks +1 line, -170 lines 0 comments Download
M chrome/test/pyautolib/pyauto.py View 1 1 chunk +169 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dennis_jeffrey
This CL moves a utility function from perf.py to pyauto.py, which enables autotests (that import ...
8 years, 7 months ago (2012-04-30 22:19:42 UTC) #1
Nirnimesh
LGTM https://chromiumcodereview.appspot.com/10271023/diff/1/chrome/test/pyautolib/pyauto.py File chrome/test/pyautolib/pyauto.py (right): https://chromiumcodereview.appspot.com/10271023/diff/1/chrome/test/pyautolib/pyauto.py#newcode4930 chrome/test/pyautolib/pyauto.py:4930: def GetCrosMemoryStats(self, duration): I recommend GetMemoryStatsonChromeOS it's easier ...
8 years, 7 months ago (2012-04-30 22:30:46 UTC) #2
dennis_jeffrey
8 years, 7 months ago (2012-04-30 22:37:43 UTC) #3
Thanks!

https://chromiumcodereview.appspot.com/10271023/diff/1/chrome/test/pyautolib/...
File chrome/test/pyautolib/pyauto.py (right):

https://chromiumcodereview.appspot.com/10271023/diff/1/chrome/test/pyautolib/...
chrome/test/pyautolib/pyauto.py:4930: def GetCrosMemoryStats(self, duration):
On 2012/04/30 22:30:46, Nirnimesh wrote:
> I recommend GetMemoryStatsonChromeOS
> it's easier to search, and cros is kinda overloaded term

Done - though I removed the "on" from the suggested name (figured it wasn't
really needed).

Powered by Google App Engine
This is Rietveld 408576698