Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 10271018: MIPS: Fix LFastLiteral to check boilerplate elements kind. (Closed)

Created:
8 years, 7 months ago by palfia
Modified:
8 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Fix LFastLiteral to check boilerplate elements kind. Port r11470 (621f96c0) Original commit message: Fix LFastLiteral to check boilerplate elements kind. Adds a missing check that the elements kind of the boilerplate object still has the expected elements kind, unoptimized code can transition the boilerplate. Corner cases might cause the optimized code to be reentered again. BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=11474

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M src/mips/lithium-codegen-mips.cc View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
palfia
8 years, 7 months ago (2012-04-30 20:29:40 UTC) #1
Michael Starzinger
8 years, 7 months ago (2012-05-02 09:37:19 UTC) #2
LGTM (although untested because MIPS doesn't compile ATM). Landed.

Powered by Google App Engine
This is Rietveld 408576698