Issue 10271016: gdata: Remove use of FindEntryByPathAsync() from file_browser_private_api.cc

Issue 10271016: gdata: Remove use of FindEntryByPathAsync() from file_browser_private_api.cc (Closed)

Created:
8 years, 7 months ago by satorux1

Modified:
8 years, 7 months ago

Reviewers:
Ben Chan

CC:
chromium-reviews, nkostylev+watch_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

gdata: Remove use of FindEntryByPathAsync() from file_browser_private_api.cc Instead use GetFileInfoByPathAsync(). This is in preparation for making FindEntryByPathAsync() private. BUG=chromium-os:30251 TEST=gdata in the file manager works as before (ex. pinned files are shown as pinned) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134680

Patch Set 1 #

Total comments: 4

Patch Set 2 : address comments #

Total comments: 2

Patch Set 3 : address comments #

Patch Set 4 : address comments #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -26 lines)			Patch
	M	chrome/browser/chromeos/extensions/file_browser_private_api.h	View		1 chunk	+4 lines, -5 lines	0 comments	Download
	M	chrome/browser/chromeos/extensions/file_browser_private_api.cc	View	1 2	2 chunks	+18 lines, -21 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ben Chan

http://codereview.chromium.org/10271016/diff/1/chrome/browser/chromeos/extensions/file_browser_private_api.cc File chrome/browser/chromeos/extensions/file_browser_private_api.cc (right): http://codereview.chromium.org/10271016/diff/1/chrome/browser/chromeos/extensions/file_browser_private_api.cc#newcode1604 chrome/browser/chromeos/extensions/file_browser_private_api.cc:1604: scoped_ptr<gdata::GDataFileProto> file_proto) { DCHECK(property_dict); DCHECK(file_proto.get()); http://codereview.chromium.org/10271016/diff/1/chrome/browser/chromeos/extensions/file_browser_private_api.cc#newcode1606 chrome/browser/chromeos/extensions/file_browser_private_api.cc:1606: property_dict->SetInteger("errorCode", error); ...

8 years, 7 months ago (2012-04-30 22:52:46 UTC) #2

satorux1

8 years, 7 months ago (2012-04-30 23:04:35 UTC) #3

Ben Chan

lgtm http://codereview.chromium.org/10271016/diff/5001/chrome/browser/chromeos/extensions/file_browser_private_api.cc File chrome/browser/chromeos/extensions/file_browser_private_api.cc (right): http://codereview.chromium.org/10271016/diff/5001/chrome/browser/chromeos/extensions/file_browser_private_api.cc#newcode1613 chrome/browser/chromeos/extensions/file_browser_private_api.cc:1613: property_dict->SetString("thumbnailUrl", file_proto->thumbnail_url()); perhaps DCHECK(file_proto.get()) here instead?

8 years, 7 months ago (2012-05-01 05:09:42 UTC) #4

satorux1

8 years, 7 months ago (2012-05-01 05:21:30 UTC) #5

submitting...

http://codereview.chromium.org/10271016/diff/5001/chrome/browser/chromeos/ext...
File chrome/browser/chromeos/extensions/file_browser_private_api.cc (right):

http://codereview.chromium.org/10271016/diff/5001/chrome/browser/chromeos/ext...
chrome/browser/chromeos/extensions/file_browser_private_api.cc:1613:
property_dict->SetString("thumbnailUrl", file_proto->thumbnail_url());
On 2012/05/01 05:09:43, Ben Chan wrote:
> perhaps DCHECK(file_proto.get()) here instead?

Done.

Expand Messages | Collapse Messages