test rename overhaul: step 14 - vm tests

test rename overhaul: step 14 - vm tests

Committed: https://code.google.com/p/dart/source/detail?r=7245

[Siggi Cherem (dart-lang), 2012-04-30 18:47:30]

This should be the last of the test rename overhaul series!

the vm has 2 suites run together. This converts the dart suite as a
StandardSuite.forDirectory...

https://chromiumcodereview.appspot.com/10271014/diff/4001/runtime/tests/vm/te...
File runtime/tests/vm/test_config.dart (right):

https://chromiumcodereview.appspot.com/10271014/diff/4001/runtime/tests/vm/te...
runtime/tests/vm/test_config.dart:14: ["runtime/tests/vm/vm_cc.status"]);
Note: I had to rename this one, so that we can use the 'forDirectory' feature in
test.dart. That feature requires that the name of the directory matches the name
of the .status file.
(so vm_dart.status became vm.status, and vm.status became vm_cc.status)

https://chromiumcodereview.appspot.com/10271014/diff/4001/runtime/tests/vm/vm...
File runtime/tests/vm/vm.status (right):

https://chromiumcodereview.appspot.com/10271014/diff/4001/runtime/tests/vm/vm...
runtime/tests/vm/vm.status:13: isolate_mirror_self_test: Skip  #
TODO(turnidge,antonm): investigate
Note: + added these 2 lines.

[Emily Fortuna, 2012-04-30 19:39:21]

lgtm, with comment.

https://chromiumcodereview.appspot.com/10271014/diff/4001/runtime/tests/vm/is...
File runtime/tests/vm/isolate_mirror_busy_test.dart (right):

https://chromiumcodereview.appspot.com/10271014/diff/4001/runtime/tests/vm/is...
runtime/tests/vm/isolate_mirror_busy_test.dart:7:
#library('IsolateMirrorBusyTest');
Did you want to change the naming scheme for these to be lower_case as well?

[Bob Nystrom, 2012-04-30 19:44:16]

lgtm

[Siggi Cherem (dart-lang), 2012-04-30 20:32:46]

https://chromiumcodereview.appspot.com/10271014/diff/4001/runtime/tests/vm/is...
File runtime/tests/vm/isolate_mirror_busy_test.dart (right):

https://chromiumcodereview.appspot.com/10271014/diff/4001/runtime/tests/vm/is...
runtime/tests/vm/isolate_mirror_busy_test.dart:7:
#library('IsolateMirrorBusyTest');
On 2012/04/30 19:39:21, Emily Fortuna wrote:
> Did you want to change the naming scheme for these to be lower_case as well?

Done.

[Ivan Posva, 2012-04-30 20:59:14]

-10

I really, really do not like the intermixing of test files and status files for
a semi-unrelated test suite in here. Please do not submit this.

There are different ways to address this concern: Separate the vm tests into two
different test suites, allow for the Dart-based vm tests to be in a
sub-directory and discover them differently, be creative with another
solution...

Thanks,
-Ivan


On 2012/04/30 20:32:46, sigmund wrote:
>
https://chromiumcodereview.appspot.com/10271014/diff/4001/runtime/tests/vm/is...
> File runtime/tests/vm/isolate_mirror_busy_test.dart (right):
> 
>
https://chromiumcodereview.appspot.com/10271014/diff/4001/runtime/tests/vm/is...
> runtime/tests/vm/isolate_mirror_busy_test.dart:7:
> #library('IsolateMirrorBusyTest');
> On 2012/04/30 19:39:21, Emily Fortuna wrote:
> > Did you want to change the naming scheme for these to be lower_case as well?
> 
> Done.

[Siggi Cherem (dart-lang), 2012-04-30 23:58:12]

PTAL

I went for option #3 from all the options I sent on the email. I liked #4 but I
couldn't change the name of the suite in the current set up (that required more
changes to test.dart that are not worth it right not).

The main difference between this and before the change are:
- moved from src -> dart
- the 2 .status files are merged (only vm.status now)
- and the dart tests have a dart/ prefix. So they are in a different namespace
than the cc tests.

[Emily Fortuna, 2012-05-01 00:13:39]

lgtm.

[Siggi Cherem (dart-lang), 2012-05-02 16:45:52]

submitting shortly. 

Ivan - as we discussed, I added a TODO to add support for the 'cc/' prefix in
vm.status. I'll work on that on a separate CL.

[Ivan Posva, 2012-05-03 12:42:28]

https://chromiumcodereview.appspot.com/10271014/diff/1015/tools/testing/dart/...
File tools/testing/dart/test_runner.dart (right):

https://chromiumcodereview.appspot.com/10271014/diff/1015/tools/testing/dart/...
tools/testing/dart/test_runner.dart:82: // the test rename overhaul is done.
Thanks!