Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Unified Diff: tests/pending_manager_test.py

Issue 102703004: Improved user-facing messages (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/commit-queue
Patch Set: Fixed quotes Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pending_manager.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/pending_manager_test.py
diff --git a/tests/pending_manager_test.py b/tests/pending_manager_test.py
index efef86f109eee3ce27deaafa82782c19fbd198f0..0407eae52bc6790daa4e402d2cd11a3c3571c3cc 100755
--- a/tests/pending_manager_test.py
+++ b/tests/pending_manager_test.py
@@ -165,19 +165,22 @@ class TestPendingManager(mocks.TestCase):
def testNoVerification(self):
try:
- # Need at least one verification.
self._get_pc([], [])
- self.fail()
- except AssertionError:
+ except ValueError:
pass
+ else:
+ self.fail(msg='A PendingManager must require at least one verifier.')
+
try:
# Cannot have the same verifier two times.
self._get_pc(
[fake.FakeVerifier(base.SUCCEEDED)],
[fake.FakeVerifier(base.SUCCEEDED)])
- self.fail()
except AssertionError:
pass
+ else:
+ self.fail(msg='A PendingManager should not accept the same verifier'
+ ' two times.')
def _check_1(self, pc, result):
issue = 31337
« no previous file with comments | « pending_manager.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698