Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 10270036: Capitalize waiting state messages that form the main content of their dialogs and make them more pr… (Closed)

Created:
8 years, 7 months ago by Jamie
Modified:
8 years, 7 months ago
Reviewers:
simonmorris
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Capitalize waiting state messages that form the main content of their dialogs and make them more prominent. As requested by UX. BUG=None TEST=Manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134750

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -7 lines) Patch
M remoting/webapp/_locales/en/messages.json View 3 chunks +8 lines, -4 lines 4 comments Download
M remoting/webapp/main.css View 1 chunk +4 lines, -0 lines 0 comments Download
M remoting/webapp/main.html View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jamie
Also cleaned up some grammar. PTAL.
8 years, 7 months ago (2012-05-01 18:24:11 UTC) #1
simonmorris
On 2012/05/01 18:24:11, Jamie wrote: > Also cleaned up some grammar. PTAL. LGTM with optional ...
8 years, 7 months ago (2012-05-01 18:30:14 UTC) #2
simonmorris
LGTM with optional suggestions. http://codereview.chromium.org/10270036/diff/1/remoting/webapp/_locales/en/messages.json File remoting/webapp/_locales/en/messages.json (right): http://codereview.chromium.org/10270036/diff/1/remoting/webapp/_locales/en/messages.json#newcode179 remoting/webapp/_locales/en/messages.json:179: "description": "Text displayed while a ...
8 years, 7 months ago (2012-05-01 18:30:30 UTC) #3
Jamie
8 years, 7 months ago (2012-05-01 19:18:58 UTC) #4
FYI

http://codereview.chromium.org/10270036/diff/1/remoting/webapp/_locales/en/me...
File remoting/webapp/_locales/en/messages.json (right):

http://codereview.chromium.org/10270036/diff/1/remoting/webapp/_locales/en/me...
remoting/webapp/_locales/en/messages.json:179: "description": "Text displayed
while a client is connecting to a host, but before the connection is
established."
On 2012/05/01 18:30:30, simonmorris wrote:
> Maybe the description should start "Footer text displayed at the client...",
for
> consistency with the next item?

It's not really a footer in the same sense that the host is. TBH, neither of
them are footers in the way that they were when these descriptions were first
written, but the host-side appears underneath some substantial UI, whereas the
client exists on its own.

http://codereview.chromium.org/10270036/diff/1/remoting/webapp/_locales/en/me...
remoting/webapp/_locales/en/messages.json:182: "message": "waiting for
connection\u2026",
On 2012/05/01 18:30:30, simonmorris wrote:
> Should this be capitalized, for consistency with the previous item?

No, for the above reason. The client-side text is pretty much the only thing in
the dialog, so it's rendered black and in sentence-case. The host-side is
incidental, so it's grey and doesn't have a capital letter.

Powered by Google App Engine
This is Rietveld 408576698