Fullscreen can't use the desktop as a parent in metro mode

Fullscreen can't use the desktop as a parent in metro mode

Also moved the rootwindow stuff to the hwnd_util and cleaned it up.

BUG=118641
TEST=see bug
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134848

[sky, 2012-05-01 15:40:39]

http://codereview.chromium.org/10270029/diff/1/ui/base/win/hwnd_util.cc
File ui/base/win/hwnd_util.cc (right):

http://codereview.chromium.org/10270029/diff/1/ui/base/win/hwnd_util.cc#newco...
ui/base/win/hwnd_util.cc:191: if (!metro) {
nit: no {}

http://codereview.chromium.org/10270029/diff/1/ui/base/win/hwnd_util.h
File ui/base/win/hwnd_util.h (right):

http://codereview.chromium.org/10270029/diff/1/ui/base/win/hwnd_util.h#newcode53
ui/base/win/hwnd_util.h:53: UI_EXPORT HWND GetRootWindow(bool is_child_window);
Is there another name we could use for this? RootWindow is also the name of a
class aura.

[cpu_(ooo_6.6-7.5), 2012-05-01 20:53:12]

code updated, please look again.

http://codereview.chromium.org/10270029/diff/1/ui/base/win/hwnd_util.h
File ui/base/win/hwnd_util.h (right):

http://codereview.chromium.org/10270029/diff/1/ui/base/win/hwnd_util.h#newcode53
ui/base/win/hwnd_util.h:53: UI_EXPORT HWND GetRootWindow(bool is_child_window);
On 2012/05/01 15:40:39, sky wrote:
> Is there another name we could use for this? RootWindow is also the name of a
> class aura.

Yeah, I noticed. Does not seem to conflict because of namespaces, but I see it
can be confusing. That is why I renamed from RootWindow to GetRootWindow.

How about 
GetOSRootWindow?

GetTopLevelWindow, the other choice is used in  src/remoting/host

Naming is hard.

[sky, 2012-05-01 21:12:00]

How about GetWindowToParentTo? And should the boolean be named fullscreen?

  -Scott

On Tue, May 1, 2012 at 1:53 PM,  <cpu@chromium.org> wrote:
> code updated, please look again.
>
>
>
> http://codereview.chromium.org/10270029/diff/1/ui/base/win/hwnd_util.h
> File ui/base/win/hwnd_util.h (right):
>
>
http://codereview.chromium.org/10270029/diff/1/ui/base/win/hwnd_util.h#newcode53
> ui/base/win/hwnd_util.h:53: UI_EXPORT HWND GetRootWindow(bool
> is_child_window);
> On 2012/05/01 15:40:39, sky wrote:
>>
>> Is there another name we could use for this? RootWindow is also the
>
> name of a
>>
>> class aura.
>
>
> Yeah, I noticed. Does not seem to conflict because of namespaces, but I
> see it can be confusing. That is why I renamed from RootWindow to
> GetRootWindow.
>
> How about
> GetOSRootWindow?
>
> GetTopLevelWindow, the other choice is used in  src/remoting/host
>
> Naming is hard.
>
> http://codereview.chromium.org/10270029/

[cpu_(ooo_6.6-7.5), 2012-05-02 00:25:51]

changed to your suggestion. PTAL

[ananta, 2012-05-02 00:42:18]

LGTM

[cpu_(ooo_6.6-7.5), 2012-05-02 01:28:07]

sky, 

I am going to check in since we want it for a demo but please let me know if
there was anything else you wanted.

[sky, 2012-05-02 03:54:36]

LGTM