Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issue 10270027: gdata: Export PlatformFileInfo/Proto conversion functions (Closed)

Created:
8 years, 7 months ago by satorux1
Modified:
8 years, 7 months ago
Reviewers:
achuithb
CC:
chromium-reviews, achuith+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

gdata: Export PlatformFileInfo/Proto conversion functions These functions will be used in an upcoming patch, when we extract file info from GDataFileProto/GDataDirectoryProto (i.e. in some places, we need PlatFormFileInfo). BUG=chromium-os:30251 TEST=GDataFileSystemTest.CachedFeedLoading Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134679

Patch Set 1 #

Total comments: 3

Patch Set 2 : address comments #

Patch Set 3 : polish #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -19 lines) Patch
M chrome/browser/chromeos/gdata/gdata_files.h View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_files.cc View 2 chunks +29 lines, -19 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
satorux1
8 years, 7 months ago (2012-04-30 23:39:57 UTC) #1
achuithb
lgtm with nits. http://codereview.chromium.org/10270027/diff/1/chrome/browser/chromeos/gdata/gdata_files.h File chrome/browser/chromeos/gdata/gdata_files.h (right): http://codereview.chromium.org/10270027/diff/1/chrome/browser/chromeos/gdata/gdata_files.h#newcode36 chrome/browser/chromeos/gdata/gdata_files.h:36: class PlatformFileInfoProto; I'd make this the ...
8 years, 7 months ago (2012-04-30 23:51:33 UTC) #2
satorux1
8 years, 7 months ago (2012-05-01 00:13:46 UTC) #3
http://codereview.chromium.org/10270027/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/gdata_files.h (right):

http://codereview.chromium.org/10270027/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_files.h:140: // Convert the proto
representation to the platform file.
On 2012/04/30 23:51:33, achuith.bhandarkar wrote:
> Can we keep all the proto methods grouped together? So maybe move this up
after
> the declaration of FromProtoString? 
> 
> Let's also keep the style consistent (one comment for both functions, and no
> newline between the declarations).

Done.

Powered by Google App Engine
This is Rietveld 408576698