gdata: Remove use of FindEntryByPathAsync() from file_manager_util.cc

gdata: Remove use of FindEntryByPathAsync() from file_manager_util.cc

Instead use GetFileInfoByPathAsync(). This is in preparation for
making FindEntryByPathAsync() private.

Along the way, get back |file_name| field in GDataFileProto, which
was once removed in crrev.com/134405, as this info was needed.

BUG=chromium-os:30251
TEST=can open both regular files hosted documents on gdata as before

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134623

[achuithb, 2012-04-30 21:45:21]

http://codereview.chromium.org/10270025/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/gdata_files.cc (right):

http://codereview.chromium.org/10270025/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_files.cc:646: file_name_ =
proto.file_name();
It's fine to do this for consistency, but maybe add a comment saying that this
name will be changed by SetFileNameFromTitle()? Alternatively you can skip this
line altogether.

http://codereview.chromium.org/10270025/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_files.cc:667:
proto->set_file_name(file_name_);
Maybe add a comment here saying that protos are also used by
GetFileInfoByPathAsync which needs this value?

[satorux1, 2012-04-30 21:52:57]

Thank you for great feedback!

http://codereview.chromium.org/10270025/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/gdata_files.cc (right):

http://codereview.chromium.org/10270025/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_files.cc:646: file_name_ =
proto.file_name();
On 2012/04/30 21:45:21, achuith.bhandarkar wrote:
> It's fine to do this for consistency, but maybe add a comment saying that this
> name will be changed by SetFileNameFromTitle()? Alternatively you can skip
this
> line altogether.

Done.

http://codereview.chromium.org/10270025/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_files.cc:667:
proto->set_file_name(file_name_);
On 2012/04/30 21:45:21, achuith.bhandarkar wrote:
> Maybe add a comment here saying that protos are also used by
> GetFileInfoByPathAsync which needs this value?

Done.

[achuithb, 2012-04-30 21:56:10]

lgtm!