ninja windows: make sure that .s files aren't passed to compiler

ninja windows: make sure that .s files aren't passed to compiler

R=thakis@chromium.org
BUG=125606
Committed: https://code.google.com/p/gyp/source/detail?r=1345

[Nico, 2012-04-30 20:13:16]

Does windows not have any standalone asm files?

Code LGTM, but maybe you can describe how asm files work with cl.exe (don't
exist, are called '.asm' which are processed by masm, or whatever it is that
happens)

[scottmg, 2012-04-30 20:52:00]

On 2012/04/30 20:13:16, Nico wrote:
> Does windows not have any standalone asm files?

It does, but only for x86 (not x64, ppc, etc.), and not via cl. Chromium uses
other tools to handle assembler, but in theory we could handle .asm
automatically which I think VS does. Added comment to that effect.

> Code LGTM, but maybe you can describe how asm files work with cl.exe (don't
> exist, are called '.asm' which are processed by masm, or whatever it is that
> happens)

Done.

[Nico, 2012-04-30 20:54:48]

http://chromiumcodereview.appspot.com/10270020/diff/5001/pylib/gyp/generator/...
File pylib/gyp/generator/ninja.py (right):

http://chromiumcodereview.appspot.com/10270020/diff/5001/pylib/gyp/generator/...
pylib/gyp/generator/ninja.py:720: # TODO(scottmg): .s files won't be handled by
the Windows compiler,
Nit: s/,/./ at the end of this line, s/but we/We/ at the start of the next

(if you haven't landed already; else don't bother)

[scottmg, 2012-04-30 20:56:50]

http://chromiumcodereview.appspot.com/10270020/diff/5001/pylib/gyp/generator/...
File pylib/gyp/generator/ninja.py (right):

http://chromiumcodereview.appspot.com/10270020/diff/5001/pylib/gyp/generator/...
pylib/gyp/generator/ninja.py:720: # TODO(scottmg): .s files won't be handled by
the Windows compiler,
On 2012/04/30 20:54:48, Nico wrote:
> Nit: s/,/./ at the end of this line, s/but we/We/ at the start of the next
> 
> (if you haven't landed already; else don't bother)

Done.