gdata: Add GDataFileSystem::GetFileInfoByPathAsync().

gdata: Add GDataFileSystem::GetFileInfoByPathAsync().

In preparation for removing GetFileInfoByPath(), which is a synchronous
function. The new function is not used in production code yet.

BUG=chromium-os:30066
TEST=add unit tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134589

[Ben Chan, 2012-04-30 18:00:42]

https://chromiumcodereview.appspot.com/10270018/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/gdata/gdata_file_system.cc (right):

https://chromiumcodereview.appspot.com/10270018/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/gdata/gdata_file_system.cc:2160: callback.Run(error,
scoped_ptr<GDataFileProto>(NULL));
nit: scoped_ptr<GDataFileProto>(NULL) -> scoped_ptr<GDataFileProto>()

https://chromiumcodereview.appspot.com/10270018/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/gdata/gdata_file_system.cc:2168:
scoped_ptr<GDataFileProto>(NULL));
ditto

https://chromiumcodereview.appspot.com/10270018/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/gdata/gdata_file_system.h (right):

https://chromiumcodereview.appspot.com/10270018/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/gdata/gdata_file_system.h:73: // if |error| is not
PLATFORM_FILE_OK, |file_info| is NULL.
nit:

if -> If

|file_info| is NULL -> |file_info| is set to NULL.

https://chromiumcodereview.appspot.com/10270018/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/gdata/gdata_file_system.h:75: scoped_ptr<GDataFileProto>
file_info)>
nit:  GDataFileProto and file_info seem mismatch.  perhaps file_proto?

https://chromiumcodereview.appspot.com/10270018/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc (right):

https://chromiumcodereview.appspot.com/10270018/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc:278: // Gets the
file info for |file_path| and compare the contents against
nit: compare -> compares

[satorux1, 2012-04-30 19:47:25]

http://codereview.chromium.org/10270018/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/gdata_file_system.cc (right):

http://codereview.chromium.org/10270018/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_file_system.cc:2160: callback.Run(error,
scoped_ptr<GDataFileProto>(NULL));
On 2012/04/30 18:00:42, Ben Chan wrote:
> nit: scoped_ptr<GDataFileProto>(NULL) -> scoped_ptr<GDataFileProto>()

Done.

http://codereview.chromium.org/10270018/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_file_system.cc:2168:
scoped_ptr<GDataFileProto>(NULL));
On 2012/04/30 18:00:42, Ben Chan wrote:
> ditto

Done.

http://codereview.chromium.org/10270018/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/gdata_file_system.h (right):

http://codereview.chromium.org/10270018/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_file_system.h:73: // if |error| is not
PLATFORM_FILE_OK, |file_info| is NULL.
On 2012/04/30 18:00:42, Ben Chan wrote:
> nit:
> 
> if -> If
> 
> |file_info| is NULL -> |file_info| is set to NULL.

Done.

http://codereview.chromium.org/10270018/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_file_system.h:75: scoped_ptr<GDataFileProto>
file_info)>
On 2012/04/30 18:00:42, Ben Chan wrote:
> nit:  GDataFileProto and file_info seem mismatch.  perhaps file_proto?

Done.

http://codereview.chromium.org/10270018/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc (right):

http://codereview.chromium.org/10270018/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc:278: // Gets the
file info for |file_path| and compare the contents against
On 2012/04/30 18:00:42, Ben Chan wrote:
> nit: compare -> compares

Done.

[Ben Chan, 2012-04-30 20:16:08]

lgtm